List Items/Approval Info Component #20317
Open
+299
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (28)
|
ajayesivan
requested review from
alwx,
AlejandroCabeza,
dlipicar,
flexsurfer,
briansztamfater and
BalogunofAfrica
ajayesivan
force-pushed
the
20090-approval-info-component
branch
3 times, most recently
from
2fa4591
to
aa7efcf
Compare
Parveshdhull
approved these changes
Jun 10, 2024
Comment on lines
+30
to
+36
| {:color (if blur? | ||
| colors/white | ||
| (colors/theme-colors colors/neutral-100 colors/white theme))}) | ||
|
|
||
| (defn description | ||
| [blur? theme] | ||
| {:color (icon-description-color blur? theme)}) |
There was a problem hiding this comment.
hi @ajayesivan, Do we need another function for description color? We don't have one for label color.
There was a problem hiding this comment.
The icon-description-color function is also used for icons. Let me know if the name is not clear enough, or if you have any other suggestions.
Comment on lines
46
to
48
| (cond | ||
| (#{:spending-cap :token-contract :network | ||
| :collectible} |
There was a problem hiding this comment.
I think case will be better choice here. wdyt?
There was a problem hiding this comment.
It is way better with case, thanks for the suggestions 😊
ilmotta
approved these changes
Jun 10, 2024
| [text/text | ||
| {:size :paragraph-1 | ||
| :weight :semi-bold | ||
| :style (style/label blur? theme)} label] |
There was a problem hiding this comment.
Quick one: There's at least another instance of this style problem in this namespace https://guide.clojure.style/#vertically-align-fn-args
There was a problem hiding this comment.
I think this is something our linter should handle, no?
There was a problem hiding this comment.
@BalogunofAfrica, we would all love to get that automated, but it's a bit hard I think. I could try myself to configure this, but it's not trivial because we could easily introduce formatting side-effects in other parts of the code because we told zprint to respect newlines. Also for zprint, this is nothing more than a vector, so I think the solution could be to somehow tell it to detect if the second argument to a vector is a map and then try to fit it on the same line as the first element.
We could also try to consult with zprint's author.
There was a problem hiding this comment.
Fixed all of the formatting issues that I found.
| :descriptor descriptor} | ||
| [quo/approval-info | ||
| (assoc state | ||
| :button-label "Edit" |
There was a problem hiding this comment.
The preview becomes more powerful/useful if we parameterize as much as we can, so the person can check in the UI how the component behaves in more scenarios. tag-label and button-label could be in the state.
BalogunofAfrica
approved these changes
Jun 10, 2024
vkjr
approved these changes
Jun 10, 2024
84% of end-end tests have passedNot executed tests (1)Failed tests (4)Click to expandClass TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (4)Click to expandClass TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (43)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestWalletOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
|
|
@Francesca-G Could you please do a design review for this PR? |
Francesca-G
reviewed
Jun 11, 2024
ajayesivan
force-pushed
the
20090-approval-info-component
branch
2 times, most recently
from
dfaa225
to
ce6b8c9
Compare
|
hi @ajayesivan, e2e failures are not PR related, thanks!
|
ajayesivan
force-pushed
the
20090-approval-info-component
branch
from
ce6b8c9
to
0c398e7
Compare
ajayesivan
force-pushed
the
20090-approval-info-component
branch
from
0c398e7
to
f2d6f83
Compare
|
Hi @ajayesivan ! I am wondering why this PR is not merged yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20090
Summary
Implements the List Items/Avatar Info component
Testing notes
Manual QA can be skipped since this PR only adds a quo component and doesn't introduce any changes outside Quo Preview.
Platforms
Areas that maybe impacted
None
Steps to test
Quo Preview -> LIst Items -> Approval Info
status: ready