Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #3243 - contact profile screen cleanup #3266

Merged
merged 1 commit into from
Feb 13, 2018

Conversation

goranjovic
Copy link
Contributor

fixes #3243

Summary:

Fixes the contact's profile screen:

  • removes status and qa screen
  • adds back keys

Steps to test:

  • Start chatting, then open contact profile

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Feb 8, 2018
@goranjovic
Copy link
Contributor Author

screenshot-2018-02-08_13 31 18 485

@goranjovic
Copy link
Contributor Author

Also fixes #3268

@goranjovic goranjovic moved this from REVIEW to TO TEST in Pipeline for QA Feb 8, 2018
@yevh-berdnyk yevh-berdnyk self-assigned this Feb 8, 2018
@yevh-berdnyk yevh-berdnyk moved this from TO TEST to IN TESTING in Pipeline for QA Feb 8, 2018
@yevh-berdnyk
Copy link
Contributor

Branch: PR-3266
Android: https://i.diawi.com/ARTWK2
iOS: https://i.diawi.com/UtXNGS

Found issues

On iOS for all contacts it’s not possible to copy or share address and public key
png 1 copy

After recovering access to existing account I see the next issues for profiles of users which I was chatted before.

Some profiles have broken profile layout and functionality:

  • username is not shown
  • profile picture differs from one in the chat, it’s nor default neither set by the user
  • address and public key are not shown, Copy to Clipboard and Share buttons for them are not available
  • nothing happens when pressing Start conversation (staying on the Profile view) and Remove from contacts (users stays in contacts).

Android:
1

iOS:
png 1

On Android for some recovered contacts I also see last login time
3

@yevh-berdnyk yevh-berdnyk moved this from IN TESTING to CONTRIBUTOR in Pipeline for QA Feb 9, 2018
@goranjovic goranjovic force-pushed the feature/other-contact-profile-3243 branch from 98b724d to baf6c13 Compare February 12, 2018 09:27
@goranjovic
Copy link
Contributor Author

goranjovic commented Feb 12, 2018

The ios menu issue was resolved in #3260 - I rebased against develop to include the fix.

The other issue is really a bug in Recover, not introduced in this PR and not within the scope of this change (to clean up the screen). We should have a separate issue for this. I thought we already had, but can't find it.

@goranjovic goranjovic moved this from CONTRIBUTOR to TO TEST in Pipeline for QA Feb 12, 2018
@status-im status-im deleted a comment from statustestbot Feb 12, 2018
@goranjovic goranjovic force-pushed the feature/other-contact-profile-3243 branch from baf6c13 to d000fe1 Compare February 13, 2018 12:54
@yevh-berdnyk yevh-berdnyk moved this from TO TEST to IN TESTING in Pipeline for QA Feb 13, 2018
@yevh-berdnyk
Copy link
Contributor

Branch: PR-3266
Android: https://i.diawi.com/aAFNNf
iOS: https://i.diawi.com/ChCKGh

Rechecked - no new issues found.
@goranjovic I've created the issue #3307 for profiles after recovery

@yevh-berdnyk yevh-berdnyk moved this from IN TESTING to MERGE in Pipeline for QA Feb 13, 2018
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer force-pushed the feature/other-contact-profile-3243 branch from d000fe1 to d1fbde8 Compare February 13, 2018 14:55
@flexsurfer flexsurfer merged commit d1fbde8 into develop Feb 13, 2018
Pipeline for QA automation moved this from MERGE to DONE Feb 13, 2018
@asemiankevich asemiankevich moved this from DONE to Cherry pick for release in Pipeline for QA Feb 13, 2018
@yenda yenda moved this from Cherry pick for release to RELEASE 0.9.14 in Pipeline for QA Feb 14, 2018
@goranjovic goranjovic deleted the feature/other-contact-profile-3243 branch April 5, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Other contact's profile needs cleanup
5 participants