Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken spec validator for screen params #3283

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Fix broken spec validator for screen params #3283

merged 1 commit into from
Feb 15, 2018

Conversation

foopang
Copy link
Contributor

@foopang foopang commented Feb 10, 2018

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Feb 10, 2018
@foopang foopang changed the title Fix broken spec validator for "Show QR Code" screen params Fix broken spec validator for screen params Feb 11, 2018
@jeluard
Copy link
Contributor

jeluard commented Feb 12, 2018

@foopang Can you detail what was broken and how it's been fixed?

@foopang
Copy link
Contributor Author

foopang commented Feb 12, 2018 •
edited
Loading

@jeluard Below 2 screens are currently broken.

  • "Show QR Code" screen: spec outdated, it does not follow the latest changes in screen params.
  • "DApp description" screen: spec missing and screen not converted to Improve screen navigation

@status-github-bot status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA Feb 12, 2018
@foopang foopang force-pushed the fix/spec-screen-params branch 2 times, most recently from b17739c to 4eab447 Compare February 13, 2018 06:06
@annadanchenko annadanchenko moved this from TO TEST to IN TESTING in Pipeline for QA Feb 15, 2018
@annadanchenko annadanchenko self-assigned this Feb 15, 2018
@annadanchenko annadanchenko moved this from IN TESTING to MERGE in Pipeline for QA Feb 15, 2018
@foopang @goranjovic
Fix broken spec validator for screen params
ce34bb4 
Signed-off-by: Goran Jovic <goranjovic@gmail.com>
@goranjovic goranjovic merged commit ce34bb4 into status-im:develop Feb 15, 2018
Pipeline for QA automation moved this from MERGE to DONE Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@goranjovic goranjovic goranjovic approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees

@annadanchenko annadanchenko

Labels
None yet
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@foopang @jeluard @goranjovic @flexsurfer @annadanchenko