-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3241] Do not use hardcoded gas price #3288
Conversation
Hey, I just want to mention that when we are signing and sending tx in status-go we are always setting suggested (by eth network) gas price and estimated gas limit if they are not provided. |
Thanks @dshulyak ! We want to own those values UI side as we have to display it and allow user to modify this default. |
(handlers/register-handler-db | ||
:wallet/update-gas-price | ||
(fn [{:keys [web3] :as db}] | ||
(ethereum/gas-price web3 #(re-frame/dispatch [:wallet/update-gas-price-success %2])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this code be moved to effects?
@rasom Updated to a |
@jeluard please resolve conflicts |
@janherich done |
If use Send Transaction from Wallet: I assume that Gas price adjustment should work for mainnet too. I’ve switched to mainnet with ropsten RPC but see 20 Gwei instead of SafeLow 1 Gwei (at least according to https://ethgasstation.info/index.php ) In the same time 1 Gwei is shown ok for testnets. |
Updated description to make sure related issue is not closed (and bounty not claimed). |
Signed-off-by: Eric Dvorsak <eric@dvorsak.fr>
relates to #3241
Summary:
Rely on geth to access current gas price
Steps to test:
status: ready