-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update status-go to develop-g9cc9982a
.
#3291
Conversation
7838ad5
to
a854ec9
Compare
Most importantly, should fix #3116 |
@mandrigin please resolve conflicts |
8a40538
to
332cc8d
Compare
@flexsurfer done |
It was checked with Android: https://i.diawi.com/kbXL3i and iOS: https://i.diawi.com/vES3kF on Android 7.0 (Samsung j7 real device), iPhoneX (iOS 11.2.2) and Android 6.0 (Nexus 5 emulator). The #3116 is not reproducible anymore. As well as keeping the device with opened App without internet connection overnight and resuming in the morning chat exchange between two contacts (enabling network connection) - also loos good and both contacts could send/receive messages. @mandrigin nice job!! Ready for merge! |
Have to return it with the major issue: Reproduction:
|
@Serhy good catch! I'll take a look tomorrow. |
Automated test results:test_send_stt_from_wallet_via_enter_contact_code:white_check_mark::Test Steps & Error message:
test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:
test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:
test_send_eth_from_wallet_sign_now:x:Test Steps & Error message:
test_transaction_send_command_group_chat:white_check_mark::Test Steps & Error message:
test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:
test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:
test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:
test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:
test_send_eth_to_request_from_wallet:x:Test Steps & Error message:
|
Here is the geth log from Android 7.0 that logs all steps below:
|
It looks like that react part is waiting for a signal that node is stopped. That thing should be fixed in status-im/status-go#663 . Will try it on simulator right now |
develop-g9cc9982a
.develop-g228bda9f
.
Automated test results:test_contact_profile_view:white_check_mark::Test Steps & Error message:
test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:
test_send_eth_to_request_in_group_chat:x:Test Steps & Error message:
test_send_stt_from_wallet_via_enter_contact_code:white_check_mark::Test Steps & Error message:
test_send_eth_to_request_from_wallet:x:Test Steps & Error message:
test_network_switch:white_check_mark::Test Steps & Error message:
test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:
test_public_chat:white_check_mark::Test Steps & Error message:
test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:
test_transaction_send_command_one_to_one_chat:x:Test Steps & Error message:
test_send_eth_from_wallet_sign_now:x:Test Steps & Error message:
test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:
test_one_to_one_chat_messages_and_delete_chat:white_check_mark::Test Steps & Error message:
test_group_chat_messages:white_check_mark::Test Steps & Error message:
|
Builds Android: https://i.diawi.com/3GY9HD and iOS: https://i.diawi.com/HABc8d tested and confirmed are good to merge! @mandrigin, @dshulyak - awesome job! |
233c597
to
c13cefa
Compare
Squashed the commits |
c13cefa
to
bcec597
Compare
develop-g228bda9f
.develop-g9cc9982a
.
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
bcec597
to
3ffe618
Compare
Summary:
status: ready