Fix latest nightly -> nigthly migration #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranjovic
approved these changes
Feb 15, 2018
flexsurfer
approved these changes
Feb 15, 2018
Automated test results:test_qr_code_and_its_value:white_check_mark::Test Steps & Error message:test_contact_profile_view:white_check_mark::Test Steps & Error message:test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:x:Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_contact_code:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message: |
yenda
approved these changes
Feb 16, 2018
|
Android: https://i.diawi.com/WHJr1m and iOS: https://i.diawi.com/GQoAr9 upgrades tested: I'm was to log in and proceed chat / wallet usage. |
janherich
force-pushed
the
bug/fix-migration-#3337
branch
from
3aa8567
to
fb4ea05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3337
Summary:
This commit just reverts previous migrations clumped into
v21and established newv22migration with the identical functionality, as it was decided that we will always support commit -> commit migrations (technically nightly -> nightly, but it's not really feasible to rely on that) to better support dogfooding.Testing notes (optional):
Test the scenario described in the ticket
status: ready