[FIX #3123] ui: fix network field overflow on long network names in profile #3345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ikysylevych, thanks for making your first pull request in status-react! ❤️ |
goranjovic
approved these changes
Feb 15, 2018
|
Hi @ikysylevych - thanks for the contribution! |
|
@ikysylevych If you feel like it you can extract this as a component ! We certainly have this need for others texts. |
jeluard
approved these changes
Feb 15, 2018
|
@jeluard I'm still learning the project structure, don't want to break things. But I hope I could extract it to a separate component soon. |
Automated test results:test_send_eth_from_wallet_sign_later:x:Test Steps & Error message:
test_browse_link_entering_url_in_dapp_view:white_check_mark::Test Steps & Error message:test_network_switch:white_check_mark::Test Steps & Error message:test_qr_code_and_its_value:x:Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_contact_code:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_group_chat:x:Test Steps & Error message:
test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message: |
flexsurfer
approved these changes
Feb 16, 2018
yenda
approved these changes
Feb 16, 2018
| (when-not (string/blank? value) | ||
| [react/text {:style styles/settings-item-value | ||
| :number-of-lines 1 | ||
| :uppercase? component.styles/uppercase?} value]) |
There was a problem hiding this comment.
can you put value on the next line please ?
There was a problem hiding this comment.
it's done. thanks.
ihor-lev
force-pushed
the
bug/profile-network-field-oveflows-screen-#3123
branch
from
2a8ad8d
to
d604209
Compare
|
Branch: PR-3345 |
|
@ikysylevych Could you squash your commits? |
ihor-lev
force-pushed
the
bug/profile-network-field-oveflows-screen-#3123
branch
from
d604209
to
2f7e1b0
Compare
|
@jeluard I squashed my commits. Thanks! |
…ames in profile settings Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
jeluard
force-pushed
the
bug/profile-network-field-oveflows-screen-#3123
branch
from
2f7e1b0
to
5f5412d
Compare
|
@ikysylevych Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3123
Summary
Introduced proportions between field title and value and ellipsis endings on text overflow.
Note: In case of longer network names, this bug may be probably reproducible even with latest ios/android devices.
status: ready