Returning expandable animations back, removing :get-max-container-area-height #3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranjovic
approved these changes
Feb 19, 2018
janherich
approved these changes
Feb 19, 2018
jeluard
approved these changes
Feb 19, 2018
| @@ -42,8 +25,7 @@ | |||
| to-change-height (if (= to-changed-height :max) | |||
| (input-utils/max-container-area-height @chat-input-margin @layout-height) | |||
| to-changed-height) | |||
| to-value (min (or to-change-height (or height @to-default-height)) | |||
| @max-height)] | |||
| to-value (or to-change-height (or height @to-default-height))] | |||
|
@alwx please indicate which bug is fixed in this RP as currently it is linked to already merged PR |
|
Branch: PR-3367 animations are great again for Console and 1x1 chat and group chat
|
flexsurfer
force-pushed
the
animations-are-back
branch
from
8d949b8
to
44b1085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like
:get-max-container-area-heightbecame useless not so long ago. More importantly, it now returns incorrect negative value which means all awesome animations introduced here #3259 don't work anymore.This PR fixes this issue, removes
:get-max-container-area-height, introduces some small changes toexpandableand make animations work again.