[FIX #3351] chat: fix extra new lines adding in the text input on enter (ios) #3373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ikysylevych Does that fix an issue we have? |
|
@jeluard Yes, it fixes the issue on iOS. However, there was probably some reason for this code. I have two assumptions:
|
|
Makes sense! It would be great if you could give it a try on android. Emulator works fine and is easy to setup. |
|
@jeluard Just checked on android. Works fine. No extra new lines and any other side effects on press enter button. |
jeluard
approved these changes
Feb 20, 2018
janherich
approved these changes
Feb 20, 2018
Automated test results:test_network_switch:white_check_mark::Test Steps & Error message:test_contact_profile_view:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_now:white_check_mark::Test Steps & Error message:test_transaction_send_command_wrong_password:white_check_mark::Test Steps & Error message:test_send_eth_from_wallet_sign_later:white_check_mark::Test Steps & Error message:test_send_stt_from_wallet_via_enter_contact_code:white_check_mark::Test Steps & Error message:test_public_chat:white_check_mark::Test Steps & Error message:test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:test_one_to_one_chat_messages_and_delete_chat:white_check_mark::Test Steps & Error message:test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_send_eth_to_request_in_group_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_in_one_to_one_chat:white_check_mark::Test Steps & Error message:test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message:test_group_chat_messages:white_check_mark::Test Steps & Error message: |
…ut on enter (ios) Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
flexsurfer
force-pushed
the
bug/extra-new-lines-input-field-ios-#3351
branch
from
096aa47
to
0a17d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Concatenation of the input text with a new line symbol "\n" looks exhaustive in iOS. But it may be required in Android. I cannot test Android at this moment. In case it fails in Android maybe we should add a platform check.
status: ready