Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4010] Allow both release and develop version to coexist #4039

Merged

Conversation

endenwer
Copy link
Contributor

@endenwer endenwer commented Apr 27, 2018

fixes #4010

Summary:

Add ability to install debug and release build together.

Steps to test:

  • Install release build
  • Install debug bulid
  • Check that two apps exist: Status and Status Debug.

Wait for the new icon.

status: ready

@jeluard
Copy link
Contributor

jeluard commented Apr 27, 2018

@endenwer Any reason why this is wip?

@endenwer
Copy link
Contributor Author

Wait for icon.

@endenwer
Copy link
Contributor Author

@jeluard Do I need to change the icon for debug build as on android?

@jeluard
Copy link
Contributor

jeluard commented Apr 27, 2018

@endenwer Yes please! @denis-sharypin will provide you those.

@endenwer
Copy link
Contributor Author

endenwer commented Apr 27, 2018

ok, I wait for #4018

@yenda
Copy link
Contributor

yenda commented Apr 29, 2018

@endenwer it seems the icon has been delivered can you udpate your PR ? #4018 (comment)

@endenwer
Copy link
Contributor Author

@jeluard @yenda Done.
simulator screen shot - iphone 6 - 2018-04-29 at 19 25 28

@status-github-bot status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA May 2, 2018
@statustestbot
Copy link

0% of end-end tests have passed

Total executed tests: 16
Failed tests: 16
Passed tests: 0

Failed tests (16)

Click to expand
1. test_send_transaction_from_daap

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

2. test_send_eth_from_wallet_sign_now

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

3. test_one_to_one_chat_messages_and_delete_chat

Looking for NextButton
Tap on NextButton

E selenium.common.exceptions.TimeoutException: Message: 'NameInput' is not found on screen, using: 'xpath://android.widget.TextView[@text='Name']', during '45' seconds

Device sessions:

4. test_send_eth_to_request_from_wallet

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

5. test_contact_profile_view

Looking for NextButton
Tap on NextButton

E selenium.common.exceptions.TimeoutException: Message: 'NameInput' is not found on screen, using: 'xpath://android.widget.TextView[@text='Name']', during '45' seconds

Device sessions:

6. test_public_chat

Looking for NextButton
Tap on NextButton

E selenium.common.exceptions.TimeoutException: Message: 'NameInput' is not found on screen, using: 'xpath://android.widget.TextView[@text='Name']', during '45' seconds

Device sessions:

7. test_network_switch

Looking for NextButton
Tap on NextButton

E selenium.common.exceptions.TimeoutException: Message: 'NameInput' is not found on screen, using: 'xpath://android.widget.TextView[@text='Name']', during '45' seconds

Device sessions:

8. test_transaction_send_command_one_to_one_chat

Looking for CreateAccountButton

E selenium.common.exceptions.NoSuchElementException: Message: 'CreateAccountButton' is not found on screen, using: 'xpath://android.widget.TextView[@text='CREATE ACCOUNT']'

Device sessions:

9. test_browse_link_entering_url_in_dapp_view

Looking for NextButton
Tap on NextButton

E selenium.common.exceptions.TimeoutException: Message: 'NameInput' is not found on screen, using: 'xpath://android.widget.TextView[@text='Name']', during '45' seconds

Device sessions:

10. test_transaction_send_command_wrong_password

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

11. test_send_eth_to_request_in_one_to_one_chat

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

12. test_send_stt_from_wallet_via_enter_recipient_address

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

13. test_send_eth_to_request_in_group_chat

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

14. test_transaction_send_command_group_chat

Looking for NextButton
Tap on NextButton

E selenium.common.exceptions.TimeoutException: Message: 'NameInput' is not found on screen, using: 'xpath://android.widget.TextView[@text='Name']', during '45' seconds

Device sessions:

15. test_send_eth_from_wallet_sign_later

Looking for IHaveAccountButton

E selenium.common.exceptions.NoSuchElementException: Message: 'IHaveAccountButton' is not found on screen, using: 'xpath://android.widget.TextView[@text='I ALREADY HAVE AN ACCOUNT']'

Device sessions:

16. test_group_chat_messages_and_delete_chat

Looking for SignInButton
Tap on SignInButton

E selenium.common.exceptions.TimeoutException: Message: 'DonNotShare' is not found on screen, using: 'xpath://*[@text="NO, I DON'T WANT TO SHARE"]', during '10' seconds

Device sessions:

@Serhy
Copy link
Contributor

Serhy commented May 2, 2018

@endenwer could you please rebase on latest develop branch, please? There was an issue (which is fixed by #4084 already!)

@endenwer endenwer force-pushed the feature/ios-multiple-builds-#4010 branch from 960d53c to 933a476 Compare May 3, 2018 01:15
@asemiankevich asemiankevich moved this from TO TEST to MERGE in Pipeline for QA May 4, 2018
@flexsurfer
Copy link
Member

flexsurfer commented May 8, 2018

hey @endenwer thanks, could you please "Allow edits from maintainers." https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

For greater collaboration, you can allow commits on branches you've created from forks. Permission to commit to your forked branches is limited to those with push access to the upstream repository of the fork. …

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer force-pushed the feature/ios-multiple-builds-#4010 branch from 933a476 to db2f8c1 Compare May 9, 2018 08:34
@flexsurfer flexsurfer merged commit db2f8c1 into status-im:develop May 9, 2018
Pipeline for QA automation moved this from MERGE to DONE May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Allow both release and develop version to coexist
7 participants