Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/User is not redirected to previous screen after scanning wallet QR code. [#3414] #4454

Merged
merged 1 commit into from May 28, 2018
Merged

Bug/User is not redirected to previous screen after scanning wallet QR code. [#3414] #4454

merged 1 commit into from May 28, 2018

Conversation

flexsurfer
Copy link
Member

fixes #3414

@flexsurfer flexsurfer self-assigned this May 25, 2018
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 25, 2018
@rasom
Copy link
Member

rasom commented May 25, 2018 •
edited by status-github-bot bot

apk uploaded to https://i.diawi.com/oLGXgu for branch PR-4454

@rasom
Copy link
Member

rasom commented May 25, 2018 •
edited by status-github-bot bot

ipa uploaded to https://i.diawi.com/pGJetT for branch PR-4454

@status-github-bot status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA May 25, 2018
@asemiankevich asemiankevich moved this from TO TEST to IN TESTING in Pipeline for QA May 25, 2018
@asemiankevich asemiankevich self-assigned this May 25, 2018
@statustestbot
Copy link

75% of end-end tests have passed

Total executed tests: 28
Failed tests: 7
Passed tests: 21

Failed tests (7)

Click to expand
1. test_send_transaction_from_daap

Scrolling down to SimpleDAppButton
Looking for SimpleDAppButton

E selenium.common.exceptions.NoSuchElementException: Message: 'SimpleDAppButton' is not found on screen, using: 'xpath://*[@text="Simple Dapp"]'

Device sessions:

2. test_faucet_console_command

Tap on SendMessageButton
Looking for full text: 'Faucet request has been received'

E Failed: Message with text "Faucet request has been received" was not received

Device sessions:

3. test_username_and_profile_picture_in_chats

Tap on ChatElement
Looking for AddToContacts

E selenium.common.exceptions.NoSuchElementException: Message: 'AddToContacts' is not found on screen, using: 'accessibility id:add-to-contacts-button'

Device sessions:

4. test_public_chat

Wait for PlusButton
Looking for an element by text: 'puislqm'

E Failed: Message '👨 ‍ 👩 ‍ 👧 ‍ 👧' was received but username is 'Excitable Wasteful Crayfish' instead of user_52512437. Message 'message with emoji 🙅 🏾 ‍ ♂ ️' was received but username is 'Excitable Wasteful Crayfish' instead of user_52512437. Message 'message with new line' was received but username is 'Excitable Wasteful Crayfish' instead of user_52512437. Message '/command' was received but username is 'Gargantuan Fussy Amethystsunbird' instead of user_525124225. Message 'ţēšț мεŝšȁǥě 犈好' was received but username is 'Gargantuan Fussy Amethystsunbird' instead of user_525124225. Message 'This is text message.' was received but username is 'Gargantuan Fussy Amethystsunbird' instead of user_525124225

Device sessions:

5. test_delete_1_1_chat

Looking for full text: 'Sent'
Looking for CommandsButton

E selenium.common.exceptions.NoSuchElementException: Message: 'CommandsButton' is not found on screen, using: 'accessibility id:chat-commands-button'

Device sessions:

6. test_transaction_send_command_one_to_one_chat

Wait for EnterPasswordInput
Looking for EnterPasswordInput

E selenium.common.exceptions.NoSuchElementException: Message: 'EnterPasswordInput' is not found on screen, using: 'accessibility id:enter-password-input'

Device sessions:

7. test_browse_link_entering_url_in_dapp_view

Tap on BrowserNextPageButton
Looking for a text part: 'Избранная статья'

E selenium.common.exceptions.TimeoutException: Message: 'BaseElement' is not found on screen, using: 'xpath://*[contains(@text, "Избранная статья")]', during '60' seconds

Device sessions:

Passed tests (21)

Click to expand
1. test_sign_transaction_twice
Device sessions:

2. test_swipe_and_delete_1_1_chat
Device sessions:

3. test_one_to_one_chat_messages
Device sessions:

4. test_copy_and_paste_messages
Device sessions:

5. test_send_eth_from_wallet_sign_now
Device sessions:

6. test_open_transaction_on_etherscan
Device sessions:

7. test_send_eth_to_request_from_wallet
Device sessions:

8. test_incorrect_password
Device sessions:

9. test_backup_seed_phrase_and_recover_account
Device sessions:

10. test_offline_messaging_1_1_chat
Device sessions:

11. test_contact_profile_view
Device sessions:

12. test_public_chat_management
Device sessions:

13. test_network_switch
Device sessions:

14. test_wallet_error_messages
Device sessions:

15. test_transaction_send_command_wrong_password
Device sessions:

16. test_send_eth_to_request_in_one_to_one_chat
Device sessions:

17. test_profile_picture
Device sessions:

18. test_switch_users
Device sessions:

19. test_set_up_wallet
Device sessions:

20. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions:

21. test_qr_code_and_its_value
Device sessions:

@statustestbot
Copy link

79% of end-end tests have passed

Total executed tests: 28
Failed tests: 6
Passed tests: 22

Failed tests (6)

Click to expand
1. test_send_transaction_from_daap

Scrolling down to SimpleDAppButton
Looking for SimpleDAppButton

E selenium.common.exceptions.NoSuchElementException: Message: 'SimpleDAppButton' is not found on screen, using: 'xpath://*[@text="Simple Dapp"]'

Device sessions:

2. test_faucet_console_command

Tap on SendMessageButton
Looking for full text: 'Faucet request has been received'

E Failed: Message with text "Faucet request has been received" was not received

Device sessions:

3. test_username_and_profile_picture_in_chats

Tap on ChatElement
Looking for AddToContacts

E selenium.common.exceptions.NoSuchElementException: Message: 'AddToContacts' is not found on screen, using: 'accessibility id:add-to-contacts-button'

Device sessions:

4. test_public_chat

Wait for PlusButton
Looking for an element by text: 'cvbpkim'

E Failed: Message '🏇 🏾' was received but username is 'Verifiable Woozy Rattlesnake' instead of user_52513504. Message 'message with emoji ⏯' was received but username is 'Verifiable Woozy Rattlesnake' instead of user_52513504. Message 'message with new line' was received but username is 'Verifiable Woozy Rattlesnake' instead of user_52513504. Message '/command' was received but username is 'Exotic Burdensome Koi' instead of user_525134924. Message 'ţēšț мεŝšȁǥě 犈好' was received but username is 'Exotic Burdensome Koi' instead of user_525134924. Message 'This is text message.' was received but username is 'Exotic Burdensome Koi' instead of user_525134924

Device sessions:

5. test_delete_1_1_chat

Looking for full text: 'Sent'
Looking for CommandsButton

E selenium.common.exceptions.NoSuchElementException: Message: 'CommandsButton' is not found on screen, using: 'accessibility id:chat-commands-button'

Device sessions:

6. test_transaction_send_command_one_to_one_chat

Wait for EnterPasswordInput
Looking for EnterPasswordInput

E selenium.common.exceptions.NoSuchElementException: Message: 'EnterPasswordInput' is not found on screen, using: 'accessibility id:enter-password-input'

Device sessions:

Passed tests (22)

Click to expand
1. test_sign_transaction_twice
Device sessions:

2. test_swipe_and_delete_1_1_chat
Device sessions:

3. test_one_to_one_chat_messages
Device sessions:

4. test_copy_and_paste_messages
Device sessions:

5. test_send_eth_from_wallet_sign_now
Device sessions:

6. test_open_transaction_on_etherscan
Device sessions:

7. test_send_eth_to_request_from_wallet
Device sessions:

8. test_incorrect_password
Device sessions:

9. test_backup_seed_phrase_and_recover_account
Device sessions:

10. test_offline_messaging_1_1_chat
Device sessions:

11. test_contact_profile_view
Device sessions:

12. test_public_chat_management
Device sessions:

13. test_network_switch
Device sessions:

14. test_wallet_error_messages
Device sessions:

15. test_browse_link_entering_url_in_dapp_view
Device sessions:

16. test_transaction_send_command_wrong_password
Device sessions:

17. test_send_eth_to_request_in_one_to_one_chat
Device sessions:

18. test_profile_picture
Device sessions:

19. test_switch_users
Device sessions:

20. test_set_up_wallet
Device sessions:

21. test_send_stt_from_wallet_via_enter_recipient_address
Device sessions:

22. test_qr_code_and_its_value
Device sessions:

@asemiankevich
Copy link
Contributor

image

@rasom
Copy link
Member

rasom commented May 25, 2018 •
edited by status-github-bot bot

apk uploaded to https://i.diawi.com/eyYkPY for branch PR-4454

@rasom
Copy link
Member

rasom commented May 26, 2018 •
edited by status-github-bot bot

ipa uploaded to https://i.diawi.com/HD1hu7 for branch PR-4454

@rasom
Copy link
Member

rasom commented May 28, 2018 •
edited by status-github-bot bot

apk uploaded to https://i.diawi.com/7cCs4J for branch PR-4454

@rasom
Copy link
Member

rasom commented May 28, 2018 •
edited by status-github-bot bot

ipa uploaded to https://i.diawi.com/WdFicm for branch PR-4454

@flexsurfer
Copy link
Member Author

@asemiankevich rebased, next build should be fine

@rasom
Copy link
Member

rasom commented May 28, 2018 •
edited by status-github-bot bot

apk uploaded to https://i.diawi.com/rrHcHY for branch PR-4454

@rasom
Copy link
Member

rasom commented May 28, 2018 •
edited by status-github-bot bot

ipa uploaded to https://i.diawi.com/o7ZjSL for branch PR-4454

@asemiankevich asemiankevich moved this from IN TESTING to MERGE in Pipeline for QA May 28, 2018
@rasom
Copy link
Member

rasom commented May 28, 2018 •
edited by status-github-bot bot

apk uploaded to https://i.diawi.com/axX2mq for branch PR-4454

@rasom
Copy link
Member

rasom commented May 28, 2018 •
edited by status-github-bot bot

ipa uploaded to https://i.diawi.com/RHdwCN for branch PR-4454

@flexsurfer
[#3414]
e972cc4 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit e972cc4 into develop May 28, 2018
Pipeline for QA automation moved this from MERGE to DONE May 28, 2018
@rasom rasom deleted the bug/3414 branch May 30, 2018 09:26
@StatusWrike StatusWrike mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@goranjovic goranjovic goranjovic approved these changes

Assignees

@flexsurfer flexsurfer

@asemiankevich asemiankevich

Labels
None yet
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User is not redirected to previous screen after scanning wallet QR code. Transaction details are lost
6 participants
@flexsurfer @rasom @statustestbot @asemiankevich @jeluard @goranjovic