[#4901]: Fix npm version issue; updated scripts/setup #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwx
changed the title
jeluard
reviewed
Jun 28, 2018
ios/Podfile.lock
Outdated
|
|
||
| DEPENDENCIES: | ||
| - FirebaseMessaging | ||
| - React (from `../node_modules/react-native`) | ||
| - react-native-background-timer (from `../node_modules/react-native-background-timer`) | ||
| - RNKeychain (from `../node_modules/react-native-keychain`) |
There was a problem hiding this comment.
Is this related to the PR?
There was a problem hiding this comment.
I get the same changes automatically in Xcode in a different PR https://github.com/status-im/status-react/pull/4988/files , probably at some point some code got through which did not update these files, so it's probably safer to include them at some point, otherwise we might be using different versions locally from prod (0.53 vs 0.55 seems like a big difference), but I know very little of mac build
ios/Podfile.lock
Outdated
|
|
||
| COCOAPODS: 1.3.1 | ||
| COCOAPODS: 1.5.3 |
There was a problem hiding this comment.
I'd rather leave pod changes out if they are not strictly mandatory.
jeluard
approved these changes
Jun 28, 2018
dmitryn
approved these changes
Jun 28, 2018
alwx
force-pushed
the
npm-fix
branch
2 times, most recently
from
03ef56e
to
61c5d15
Compare
Signed-off-by: Aleksandr Pantiukhov <alwxndr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4901
Tested on node v7.10.1 (npm v5.5.1) and node v9.11.2 (npm v6.1.0).
Node 10 is not supported by Realm: realm/realm-js#1813
Also updated our build scripts, added the installation of Clojure CLI there (to build status with
clj-rn) and made sure it works.