Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update status js api according to latest changes in web3 opt-in EIP #5648

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Update status js api according to latest changes in web3 opt-in EIP #5648

merged 1 commit into from
Aug 29, 2018

Conversation

flexsurfer
Copy link
Member

@flexsurfer flexsurfer self-assigned this Aug 27, 2018
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Aug 27, 2018
@status-comment-bot
Copy link

status-comment-bot commented Aug 27, 2018 •
edited by status-github-bot bot

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5648/1/

@status-comment-bot
Copy link

status-comment-bot commented Aug 27, 2018 •
edited by status-github-bot bot

Branch: PR-5648, Android build uploaded to diawi: https://i.diawi.com/pkUxtj

@status-github-bot status-github-bot bot moved this from REVIEW to TO TEST in Pipeline for QA Aug 27, 2018
@lukaszfryc
Copy link
Contributor

Hey @flexsurfer! What tests it makes sense to do here? Anything else besides transactions in dapps (including Status Test DApp) and basic smoke test?

@Serhy Serhy moved this from TO TEST to IN TESTING in Pipeline for QA Aug 28, 2018
@flexsurfer
Copy link
Member Author

@lukaszfryc just check if you can access contact code in Test Dapp, that should be enough

@status-comment-bot
Copy link

status-comment-bot commented Aug 28, 2018 •
edited by status-github-bot bot

Desktop Jenkins build job started at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5648/2/

@status-comment-bot
Copy link

status-comment-bot commented Aug 28, 2018 •
edited by status-github-bot bot

Desktop Jenkins build was failed or cancelled. More details at https://ci.status.im/job/status-react/job/desktop/job/pull-requests/job/PR-5648/2/

@statustestbot
Copy link

81% of end-end tests have passed

Total executed tests: 58
Failed tests: 11
Passed tests: 47

Failed tests (11)

Click to expand
1. test_password_in_logcat_sign_in

Device 1: Wait for ShareMyContactKeyButton
Device 1: Scrolling down to LogoutButton

name 'info' is not defined, also Unexpected Alert is shown: 'Are you sure you want to log out?'

Device sessions

2. test_logcat_send_transaction_from_daap

Device 1: Tap on SignTransactionButton
Device 1: Wait for ProgressBar

Device 1: 'GotItButton' is not found on the screen, also Unexpected Alert is shown: 'Error: Doesn't support name:

This error is located at:
in asset-selector
in reagent101
in RCTView
in RCTView
in RCTScrollView
in ScrollView
in RCTView
in RCTView
in reagent41
in reagent97
in send-transaction-modal
in reagent96
in RCTView
in RCTView
in reagent14
in RCTView
in main-screen-modal-view
in reagent95
in RCTView
in RCTModalHostView
in t
in RCTView
in main-modal
in reagent3
in RCTView
in main
in root
in reagent1
in RCTView
in RCTView
in t'

Device sessions

3. test_token_with_more_than_allowed_decimals

Device 1: Type '0.05188093' to AmountEditBox
Device 1: Looking for an element by text: 'Amount is too precise. Max number of decimals is 7.'

Warning about too precise amount is not shown when requesting a transaction

Device sessions

4. test_logcat_send_transaction_in_1_1_chat

Device 1: Tap on SignTransactionButton
Device 1: Wait for ProgressBar

Device 1: 'GotItButton' is not found on the screen, also Unexpected Alert is shown: 'replacement transaction underpriced'

Device sessions

5. test_request_and_receive_eth_in_1_1_chat

Device 1: Tap on SignTransactionButton
Device 1: Wait for ProgressBar

Device 1: 'GotItButton' is not found on the screen, also Unexpected Alert is shown: 'Error: Doesn't support name:

This error is located at:
in asset-selector
in reagent109
in RCTView
in RCTView
in RCTScrollView
in ScrollView
in RCTView
in RCTView
in reagent14
in reagent55
in reagent105
in send-transaction
in reagent104
in RCTView
in main
in root
in reagent1
in RCTView
in RCTView
in t'

Device sessions

6. test_swipe_to_delete_public_chat

Device 1: Wait for ShareMyContactKeyButton
Device 1: Scrolling down to LogoutButton

name 'info' is not defined, also Unexpected Alert is shown: 'Are you sure you want
to log out?'

Device sessions

7. test_network_mismatch_for_send_request_commands

Device 1: Tap on CommandsButton
Device 1: Tap on RequestCommand

Device 1: 'BaseButton' is not found on the screen

Device sessions

8. test_backup_recovery_phrase

Device 1: Wait for ShareMyContactKeyButton
Device 1: Scrolling down to LogoutButton

name 'info' is not defined, also Unexpected Alert is shown: 'Are you sure you want
to log out?'

Device sessions

9. test_transaction_confirmed_on_sender_side

Device 1: Looking for a message by text: '0.0828163228'
Device 1: StatusText is Sent

Transaction with amount 0.0828163228 was not confirmed, address is 616874dc6cc2810cdc930dea26496fcf217d58ca

Device sessions

10. test_request_eth_in_wallet

Device 2: Wait for ChatMessageInput
Device 2: Looking for a message by text: '0.0828162923'

Request funds message was not received

Device sessions

11. test_transaction_confirmed_on_recipient_side

Device 2: Wait for ChatMessageInput
Device 2: Looking for a message by text: '0.08281633'

Device 2: Transaction state is not updated on the recipient side

Device sessions

Passed tests (47)

Click to expand
1. test_create_account
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_delete_cut_and_paste_messages
Device sessions

7. test_deploy_contract_from_daap
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_back_forward_buttons_browsing_website
Device sessions

10. test_set_profile_picture
Device sessions

11. test_text_message_1_1_chat
Device sessions

12. test_add_to_contacts
Device sessions

13. test_home_view
Device sessions

14. test_send_and_open_links
Device sessions

15. test_transaction_message_sending_from_wallet
Device sessions

16. test_copy_contact_code_and_wallet_address
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_message_marked_as_sent_and_seen_1_1_chat
Device sessions

19. test_send_token_with_7_decimals
Device sessions

20. test_offline_messaging_1_1_chat
Device sessions

21. test_send_eth_from_wallet_to_address
Device sessions

22. test_send_transaction_details_in_1_1_chat
Device sessions

23. test_request_eth_in_status_test_dapp
Device sessions

24. test_manage_assets
Device sessions

25. test_wallet_set_up
Device sessions

26. test_send_emoji
Device sessions

27. test_add_contact_by_pasting_public_key
Device sessions

28. test_logcat_recovering_account
Device sessions

29. test_messaging_in_different_networks
Device sessions

30. test_send_tokens_in_1_1_chat
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_resend_message_offline
Device sessions

33. test_swipe_to_delete_1_1_chat
Device sessions

34. test_send_stt_from_wallet
Device sessions

35. test_send_eth_in_1_1_chat
Device sessions

36. test_login_with_new_account
Device sessions

37. test_send_eth_from_wallet_to_contact
Device sessions

38. test_add_contact_from_public_chat
Device sessions

39. test_send_request_not_enabled_tokens
Device sessions

40. test_send_message_to_newly_added_contact
Device sessions

41. test_password_in_logcat_creating_account
Device sessions

42. test_offline_status
Device sessions

43. test_open_google_com_via_open_dapp
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_refresh_button_browsing_app_webview
Device sessions

47. test_recover_account
Device sessions

@Serhy
Copy link
Contributor

Serhy commented Aug 29, 2018

LGTM. Autotests reviewed and confirmed not this PR issue and will be addressed separately.

@Serhy Serhy moved this from IN TESTING to MERGE in Pipeline for QA Aug 29, 2018
@Serhy Serhy mentioned this pull request Aug 29, 2018
Closed
@flexsurfer
update status js api according to latest changes in web3 opt-in EIP
b754092 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit b754092 into develop Aug 29, 2018
Pipeline for QA automation moved this from MERGE to DONE Aug 29, 2018
@rasom rasom deleted the feature/update-status-api branch September 3, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@goranjovic goranjovic goranjovic approved these changes

Assignees

@flexsurfer flexsurfer

Labels
Tested - OK
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@flexsurfer @status-comment-bot @lukaszfryc @statustestbot @Serhy @jeluard @goranjovic