Generate the build number at the beginning of the build #6894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
jakubgs
force-pushed
the
fix-build-numbers
branch
5 times, most recently
from
6c2d199
to
0e19f56
Compare
jakubgs
changed the title
jakubgs
requested review from
mandrigin,
pedropombeiro,
jeluard,
gnl,
flexsurfer and
yenda
jeluard
approved these changes
Nov 27, 2018
mandrigin
suggested changes
Nov 27, 2018
| # Example: 1812011805 | ||
| date '+%y%m%d%H%M' | tee "${BUILD_NUMBER_FILE}" | ||
| # Format: Year(2 digit) + Month + Day + Hour | ||
| # Example: 2018120118 |
There was a problem hiding this comment.
The comment is wrong now. Why this change, btw?
There was a problem hiding this comment.
I've removed minutes to reduce possibility of getting different build numbers for different platforms.
pedropombeiro
suggested changes
Nov 28, 2018
Closed
|
@jakubgs I've checked Android and iOS builds from #6894 (comment) and it's good! Both apps has (2018112717) version. Could you please review comments above about comments (sorry for tautoligies! :) inside PR so we could proceed as we need this changes in 0.9.32 release. |
jakubgs
force-pushed
the
fix-build-numbers
branch
2 times, most recently
from
508adbe
to
261e6f6
Compare
pedropombeiro
approved these changes
Nov 28, 2018
Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
fix-build-numbers
branch
from
261e6f6
to
7e031e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the build number at the beginning of the build to avoid mismatched numbers.
Resolves. #6881