Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build numbers for release builds #7028

Merged
merged 1 commit into from Dec 6, 2018
Merged

fix build numbers for release builds #7028

merged 1 commit into from Dec 6, 2018

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Dec 6, 2018 •
edited by chadyj

Fixes #7027

fix for wrong build numbers in release

@jakubgs jakubgs self-assigned this Dec 6, 2018
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Dec 6, 2018
@jakubgs jakubgs mentioned this pull request Dec 6, 2018
Closed
@jakubgs
fix build numbers for release builds
6c6d9bc 
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit 6c6d9bc into develop Dec 6, 2018
Pipeline for QA automation moved this from REVIEW to DONE Dec 6, 2018
@jakubgs jakubgs deleted the fix-release-build-numbers branch December 6, 2018 14:03
@chadyj chadyj mentioned this pull request Dec 6, 2018
Closed
@status-comment-bot
Copy link

✅ #1 CI BUILD SUCCESSFUL in 24 min and counting (29f1a33394f683db95ea2ff211f50c7647e97cf9)
Android (e2e) iOS (e2e) MacOS AppImage Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedropombeiro pedropombeiro pedropombeiro approved these changes

@mandrigin mandrigin mandrigin approved these changes

@jeluard jeluard Awaiting requested review from jeluard

@gnl gnl Awaiting requested review from gnl

@rasom rasom Awaiting requested review from rasom

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

Assignees

@jakubgs jakubgs

Labels
None yet
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9999 instead of 2018120610 is shown in About for iOS version on TestFlight
4 participants
@jakubgs @status-comment-bot @pedropombeiro @mandrigin