Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new status-go and rename NotifyUsers #7294

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Use new status-go and rename NotifyUsers #7294

merged 1 commit into from
Jan 24, 2019

Conversation

pedropombeiro
Copy link
Contributor

@pedropombeiro pedropombeiro commented Jan 17, 2019 •
edited

Summary:

This PR incorporates status-im/status-go#1352

Testing notes (optional):

Although this is a simple change, it's maybe a good idea to try it out on iOS and one desktop platform just to make sure.

status: ready

@pedropombeiro pedropombeiro self-assigned this Jan 17, 2019
@status-github-bot
Copy link

status-github-bot bot commented Jan 17, 2019 •
edited by pedropombeiro

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jan 17, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jan 17, 2019 •
edited

Jenkins Builds

Click to see older builds (14)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e5eacb7 #1 2019-01-17 23:05:46 ~14 min macos 📦 package
✔️ e5eacb7 #1 2019-01-17 23:05:47 ~14 min android 📦 package
✔️ e5eacb7 #1 2019-01-17 23:07:45 ~16 min ios 📦 package
✔️ e5eacb7 #1 2019-01-17 23:07:53 ~16 min ios-e2e 📦 package
✔️ e5eacb7 #1 2019-01-17 23:09:04 ~17 min windows 📦 package
✔️ e5eacb7 #1 2019-01-17 23:11:48 ~20 min linux 📦 package
✔️ e5eacb7 #1 2019-01-17 23:13:42 ~22 min android-e2e 📦 package
❌ 475cac5 #2 2019-01-18 13:23:32 ~44 sec ios-e2e 📄 build log
❌ 475cac5 #2 2019-01-18 13:23:38 ~49 sec ios 📄 build log
❌ 475cac5 #2 2019-01-18 13:32:31 ~9 min 44 sec android 📄 build log
❌ 475cac5 #2 2019-01-18 13:32:34 ~9 min 48 sec android-e2e 📄 build log
❌ 475cac5 #2 2019-01-18 13:35:04 ~12 min macos 📄 build log
❌ 475cac5 #2 2019-01-18 13:39:35 ~16 min windows 📄 build log
❌ 475cac5 #2 2019-01-18 13:50:38 ~27 min linux 📄 build log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a72908a #3 2019-01-18 13:30:10 ~43 sec ios 📄 build log
❌ a72908a #3 2019-01-18 13:30:10 ~45 sec ios-e2e 📄 build log
✔️ fedc822 #4 2019-01-18 13:44:35 ~14 min ios-e2e 📦 package
✔️ fedc822 #4 2019-01-18 13:44:56 ~14 min ios 📦 package
✔️ fedc822 #3 2019-01-18 13:47:51 ~15 min android 📦 package
✔️ fedc822 #3 2019-01-18 13:48:23 ~15 min android-e2e 📦 package
✔️ fedc822 #3 2019-01-18 13:48:58 ~13 min macos 📦 package
✔️ fedc822 #3 2019-01-18 13:59:37 ~19 min windows 📦 package

@status-im-auto
Copy link
Member

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e5eacb7 #1 2019-01-17 23:05:46 ~14 min macos 📦 package
✔️ e5eacb7 #1 2019-01-17 23:05:47 ~14 min android 📦 package

@pedropombeiro pedropombeiro mentioned this pull request Jan 18, 2019
Closed
@pedropombeiro
Copy link
Contributor Author

@annadanchenko @asemiankevich is it possible to do a quick test on this PR without waiting for reviews? We need to implement the change from status-go ASAP.

@asemiankevich
Copy link
Contributor

sure, no changing fleets? maybe i can run e2e for this too? @pombeirp

@antdanchenko
Copy link
Contributor

antdanchenko commented Jan 18, 2019 •
edited

@pombeirp, @asemiankevich all tests are failed against this PR due to super long (2 minutes) account creation, detailed results will be posted in ~10 minutes

@annadanchenko
Copy link

annadanchenko commented Jan 18, 2019 •
edited

@pombeirp I can confirm that creating account on iOS and Android takes very long time, so it's not e2e fault but something is wrong with build
full logcat:
logcat2.txt

logcat contains


01-18 13:22:01.012 15441 15529 E StatusModule: StartNode failed: {"error":"Key: 'NodeConfig.ShhextConfig.BackupDisabledDataDir' Error:Field validation for 'BackupDisabledDataDir' failed on the 'required' tag"}
01-18 13:22:01.013 15441 15529 D ServiceConnector: Sending message to service: 
01-18 13:22:01.013 15441 15441 D StatusService: Received service message.{ when=0 what=0 target=im.status.ethereum.module.StatusService$IncomingHandler }
01-18 13:22:01.078  6929  6929 I PhenotypeExpConfig: refreshConfiguration() : Force = false : UpdateAvailable = false : Age = 189 minutes : MaxAge = 720 minutes
01-18 13:22:01.125 15441 15494 D ReactNativeJS: DEBUG [status-im.utils.handlers:34] - Handling re-frame event:  :show-tab-bar
01-18 13:22:02.061 11343 11360 I Finsky  : [123] com.google.android.finsky.bo.an.run(6): Stats for Executor: VerifyAppsDataStore com.google.android.finsky.bo.ao@b55a25[Running, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 22]
01-18 13:22:02.073 11343 11360 I Finsky  : [123] com.google.android.finsky.bo.an.run(6): Stats for Executor: Db-verify_apps.db com.google.android.finsky.bo.ao@c4cd7fa[Running, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 29]
01-18 13:22:03.569 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.JobSchedulerEngine$PhoneskyJobSchedulerJobService.onStartJob(8): onJobSchedulerWakeup with jobId 9000
01-18 13:22:03.582 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.ad.a(25): Scheduling fallback job with id: 9034, and delay: 43200000 ms
01-18 13:22:03.598 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.ad.a(41): Scheduling fallback in 64799993 (absolute: 76839320)
01-18 13:22:03.633 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.al.handleMessage(16): DeviceState: DeviceState{currentTime=1547814123623, isCharging=true, isIdle=false, netAny=true, netNotRoaming=true, netUnmetered=true}
01-18 13:22:03.645 11343 15532 I Finsky  : [256] com.google.android.finsky.scheduler.bp.b(89): Jobs in database: 1-1337 12-1 26-1414141414 
01-18 13:22:03.651 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.ag.a(59): Running job: 12-1
01-18 13:22:03.652 11343 11343 I Finsky  : [2] com.google.android.finsky.contentsync.ContentSyncJob.a(24): ContentSyncJob started
01-18 13:22:03.656 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.ag.a(105): RunningQueue size: 1, PendingQueue size: 0
01-18 13:22:03.658 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.ag.a(116): Running queue: 12-1 
01-18 13:22:04.097 11343 11343 I Finsky  : [2] com.google.android.finsky.m.c.a(21): Completed 1 account content syncs with 1 successful.
01-18 13:22:04.107 11343 11343 I Finsky  : [2] com.google.android.finsky.contentsync.ContentSyncJob.a(22): Installation state replication succeeded.
01-18 13:22:04.109 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.bm.b(8): jobFinished: 12-1. TimeElapsed: 458ms
01-18 13:22:04.111 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.ag.a(139): Job 12-1 finished
01-18 13:22:04.116 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.ag.a(105): RunningQueue size: 0, PendingQueue size: 0
01-18 13:22:04.117 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.al.handleMessage(42): Executor finished
01-18 13:22:04.161 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.bp.b(89): Jobs in database: 1-1337 26-1414141414 
01-18 13:22:04.166 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.k.a(69): ConstraintMapping: 1-1337,  -> L: 2955561ms, D: 40924335ms, C: false, I: false, N: 1
01-18 13:22:04.169 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.k.a(69): ConstraintMapping: 26-1414141414,  -> L: 31756807ms, D: 32656807ms, C: false, I: false, N: 0
01-18 13:22:04.174 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.JobSchedulerEngine.a(109): Cancelling existing job with id: 9003
01-18 13:22:04.178 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.JobSchedulerEngine.a(48): Scheduling job Id: 9001, L: 2955561, D: 40924335, C: false, I: false, N: 1
01-18 13:22:04.182 11343 11343 I Finsky  : [2] com.google.android.finsky.scheduler.JobSchedulerEngine.a(48): Scheduling job Id: 9002, L: 31756807, D: 32656807, C: false, I: false, N: 0

@Serhy
Copy link
Contributor

Serhy commented Jan 18, 2019

Same with release Android 7 (Samsung J7) - account. Creating your account... screen with spinner stays for 2+ minutes before Home page appears.

@statustestbot
Copy link

2% of end-end tests have passed

Total executed tests: 58
Failed tests: 57
Passed tests: 1

Failed tests (57)

Click to expand
1. test_create_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

2. test_user_can_switch_network

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

3. test_filters_from_daap

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

4. test_copy_and_paste_messages

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

5. test_send_transaction_from_daap

Device 1: Scrolling down to AdvancedButton
Device 1: Scrolling down to AdvancedButton

'NoneType' object has no attribute 'click'

Device sessions

6. test_request_and_receive_tokens_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

7. test_delete_cut_and_paste_messages

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

8. test_deploy_contract_from_daap

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

9. test_offline_login

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

10. test_pass_phrase_validation

Device 1: Tap on ConfirmPhraseButton
Device 1: Wait for ProfileButton

Something went wrong. Probably, could not reach the home screen out.

Device sessions

11. test_public_chat_messaging

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

12. test_password_in_logcat_sign_in

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

13. test_set_profile_picture

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

14. test_text_message_1_1_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

15. test_add_to_contacts

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

16. test_unread_messages_counter_1_1_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

17. test_logcat_send_transaction_from_daap

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

19. test_logcat_send_transaction_from_wallet

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

20. test_send_token_with_7_decimals

Device 1: Tap on StartNewChatButton
Device 1: Wait for PublicKeyEditBox

Device 1: 'PublicKeyEditBox' is not found on the screen

Device sessions

21. test_modify_transaction_fee_values

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

22. test_token_with_more_than_allowed_decimals

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

23. test_send_eth_from_wallet_to_address

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

24. test_send_transaction_details_in_1_1_chat

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

25. test_manage_assets

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

26. test_wallet_set_up

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

27. test_logcat_send_transaction_in_1_1_chat

Device 1: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

28. test_request_and_receive_eth_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

29. test_swipe_to_delete_public_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access

Device 1: Wait for HomeButton
Device 1: Wait for ProfileButton

Device 1: Something went wrong. Probably, could not reach the home screen out.

Device sessions

31. test_send_emoji

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

32. test_add_contact_by_pasting_public_key

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

33. test_messaging_in_different_networks

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

34. test_send_tokens_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

35. test_network_mismatch_for_send_request_commands

Device 2: Tap on NextButton
Device 2: Looking for an element by text part: 'Display name'

Device 2: 'BaseButton' is not found on the screen

Device sessions

36. test_logcat_sign_message_from_daap

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

37. test_swipe_to_delete_1_1_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

38. test_switch_users_and_add_new_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

39. test_send_stt_from_wallet

Device 1: Tap on StartNewChatButton
Device 1: Wait for PublicKeyEditBox

Device 1: 'PublicKeyEditBox' is not found on the screen

Device sessions

40. test_send_eth_in_1_1_chat

Device 2: Wait for HomeButton
Device 1: Tap on WalletButton

Device 1: 'WalletButton' is not found on the screen

Device sessions

41. test_login_with_new_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

42. test_send_eth_from_wallet_to_contact

Device 1: Tap on StartNewChatButton
Device 1: Wait for PublicKeyEditBox

Device 1: 'PublicKeyEditBox' is not found on the screen

Device sessions

43. test_add_contact_from_public_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

44. test_send_request_not_enabled_tokens

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

45. test_send_message_to_newly_added_contact

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

46. test_password_in_logcat_creating_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

47. test_backup_recovery_phrase

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

48. test_offline_status

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

49. test_open_google_com_via_open_dapp

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

50. test_unread_messages_counter_public_chat

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

51. test_sign_message_from_daap

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

52. test_user_can_remove_profile_picture

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

53. test_share_contact_code_and_wallet_address

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

54. test_request_eth_in_wallet

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

55. test_refresh_button_browsing_app_webview

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

56. test_backup_recovery_phrase_warning_from_wallet

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

57. test_recover_account

Device 1: Tap on NextButton
Device 1: Looking for an element by text part: 'Display name'

Device 1: 'BaseButton' is not found on the screen

Device sessions

Passed tests (1)

Click to expand
1. test_logcat_recovering_account
Device sessions

@mandrigin
Copy link
Contributor

mandrigin commented Jan 18, 2019 •
edited by status-github-bot bot

status-go has one commit that breaks it, right.
https://github.com/status-im/status-go/tree/release/0.19 should be a base for this status-go build

GitHub
The Status module that consumes go-ethereum. Contribute to status-im/status-go development by creating an account on GitHub.

@mandrigin
Copy link
Contributor

@annadanchenko thanks a lot for this log, it helped a ton!

@mandrigin
Copy link
Contributor

@pombeirp @annadanchenko I will build a new release now, update this PR and it should fix the issue

@mandrigin
Copy link
Contributor

@annadanchenko @pombeirp @antdanchenko updated, lets see how it works now

@annadanchenko
Copy link

jenkins/prs/ios — This commit cannot be built @mandrigin @jakubgs

@mandrigin
Copy link
Contributor

@annadanchenko my mistake, sorry

@mandrigin
Copy link
Contributor

it is fixed now

@cammellos
Copy link
Member

cammellos commented Jan 18, 2019 •
edited by status-github-bot bot

I have another bugfix , could you please hold on merging in case the test is ok? https://github.com/status-im/status-go/pull/1354/files , sorry for the inconvenience

GitHub
The migration from unencrypted->encrypted did not work properly, it was deleting and re-creating the database. This correctly migrates the db. I really thought I tested it and was fine, but I mu...

@annadanchenko
Copy link

on iOS build 4 and Android build 3 can create account
testing is blocked on Windows because same #7299 happens here

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 58
Failed tests: 0
Passed tests: 58

Passed tests (58)

Click to expand
1. test_create_account
Device sessions

2. test_user_can_switch_network
Device sessions

3. test_filters_from_daap
Device sessions

4. test_copy_and_paste_messages
Device sessions

5. test_send_transaction_from_daap
Device sessions

6. test_request_and_receive_tokens_in_1_1_chat
Device sessions

7. test_delete_cut_and_paste_messages
Device sessions

8. test_deploy_contract_from_daap
Device sessions

9. test_offline_login
Device sessions

10. test_pass_phrase_validation
Device sessions

11. test_public_chat_messaging
Device sessions

12. test_password_in_logcat_sign_in
Device sessions

13. test_set_profile_picture
Device sessions

14. test_text_message_1_1_chat
Device sessions

15. test_add_to_contacts
Device sessions

16. test_unread_messages_counter_1_1_chat
Device sessions

17. test_logcat_send_transaction_from_daap
Device sessions

18. test_onboarding_screen_when_requesting_tokens_for_new_account
Device sessions

19. test_logcat_send_transaction_from_wallet
Device sessions

20. test_send_token_with_7_decimals
Device sessions

21. test_modify_transaction_fee_values
Device sessions

22. test_token_with_more_than_allowed_decimals
Device sessions

23. test_send_eth_from_wallet_to_address
Device sessions

24. test_send_transaction_details_in_1_1_chat
Device sessions

25. test_manage_assets
Device sessions

26. test_wallet_set_up
Device sessions

27. test_logcat_send_transaction_in_1_1_chat
Device sessions

28. test_request_and_receive_eth_in_1_1_chat
Device sessions

29. test_swipe_to_delete_public_chat
Device sessions

30. test_passphrase_whitespaces_ignored_while_recovering_access
Device sessions

31. test_send_emoji
Device sessions

32. test_add_contact_by_pasting_public_key
Device sessions

33. test_logcat_recovering_account
Device sessions

34. test_messaging_in_different_networks
Device sessions

35. test_send_tokens_in_1_1_chat
Device sessions

36. test_network_mismatch_for_send_request_commands
Device sessions

37. test_logcat_sign_message_from_daap
Device sessions

38. test_swipe_to_delete_1_1_chat
Device sessions

39. test_switch_users_and_add_new_account
Device sessions

40. test_send_stt_from_wallet
Device sessions

41. test_send_eth_in_1_1_chat
Device sessions

42. test_login_with_new_account
Device sessions

43. test_send_eth_from_wallet_to_contact
Device sessions

44. test_add_contact_from_public_chat
Device sessions

45. test_send_request_not_enabled_tokens
Device sessions

46. test_send_message_to_newly_added_contact
Device sessions

47. test_password_in_logcat_creating_account
Device sessions

48. test_backup_recovery_phrase
Device sessions

49. test_offline_status
Device sessions

50. test_open_google_com_via_open_dapp
Device sessions

51. test_unread_messages_counter_public_chat
Device sessions

52. test_sign_message_from_daap
Device sessions

53. test_user_can_remove_profile_picture
Device sessions

54. test_share_contact_code_and_wallet_address
Device sessions

55. test_request_eth_in_wallet
Device sessions

56. test_refresh_button_browsing_app_webview
Device sessions

57. test_backup_recovery_phrase_warning_from_wallet
Device sessions

58. test_recover_account
Device sessions

@annadanchenko
Copy link

I have another bugfix , could you please hold on merging in case the test is ok?

@cammellos do you mean if test with creating account is ok or if we complete testing of this PR and find no more issues?

@annadanchenko
Copy link

@pombeirp currently, testing on all desktop builds are blocked by #7299 we will continue testing on mobile but need new build when #7299 will be fixed to recheck on desktop

@cammellos
Copy link
Member

@annadanchenko if you complete testing for this PR and find no issues, I would like to add a commit for status-go on top (it's a small fix), fixing the ios issue

@Serhy
Copy link
Contributor

Serhy commented Jan 18, 2019 •
edited by status-github-bot bot

There is no Group Chat visible on iOS device using who upgraded from 0.9.32 build on to this PR build (https://i.diawi.com/mb6d7z) and user who uses 0.9.32 Release version.

Steps to reproduce:

  1. On iOS (12.1.2 in my case) and Android install release 0.9.32 app version and create new accounts on both devices (UseriOS and UserAndroid)
  2. UseriOS adds UserAndroid in contacts
  3. UseriOS creates Group Chat with UserAndroid (e.g. with title GroupChatiOS)
  4. UserAndroid creates Group Chat with UseriOS (e.g. with title GroupChatAndroid)
  5. UseriOS upgrades to build made off this PR (https://i.diawi.com/mb6d7z)
  6. USeriOS logs in, navigates to GroupChats and taps JOIN CHAT. UseriOS sends messages in those Group Chats. UserAndroid (who still on 0.9.32 version also sends messages)

Actual result: None of messages are received by both iOS and Android user. They can't communicate in GroupChats. If to create new Group Chat by any of iOS and Android - new GroupChat also won't appear on Home screen on any side.

@cammellos
Copy link
Member

@pombeirp desktop, I just tried on linux, I think a commit has been lost while force pushing

@churik
Copy link
Member

churik commented Jan 23, 2019

Same for Mac OS.
Log: Status.log

@cammellos
Copy link
Member

It's a config change, BackupDisabledDataDir was before defaulted in status-go to DataDir, now it's not defaulted anymore, so I will explicitly pass it.

mandrigin
mandrigin reviewed Jan 23, 2019
View reviewed changes
src/status_im/utils/platform.cljs Outdated
@@ -28,8 +28,7 @@
(def platform-specific
(cond
android? android/platform-specific
ios? ios/platform-specific
:else desktop/platform-specific))
ios? ios/platform-specific))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this change does...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch changed wrong line!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, mistakenly commited that change

@cammellos cammellos force-pushed the feature/use-send-data-notification branch from c82d832 to af9797e Compare January 23, 2019 15:51
@cammellos
Copy link
Member

we are having some jenkins trouble, can't build, @jakubgs is looking into it

@cammellos cammellos force-pushed the feature/use-send-data-notification branch from af9797e to c0071af Compare January 23, 2019 16:50
@churik
Copy link
Member

churik commented Jan 23, 2019 •
edited

@cammellos tested https://ci.status.im/blue/organizations/jenkins/status-react%2Fprs%2Fmacos/detail/PR-7294/15/artifacts build and got stuck in creating account after set up a password.
Log: Status.log

@cammellos
Copy link
Member

@churik thanks, rebuilding now, I will test it and let you know

@cammellos cammellos force-pushed the feature/use-send-data-notification branch 2 times, most recently from 85e26a8 to 25ac147 Compare January 24, 2019 05:55
@cammellos
Copy link
Member

@annadanchenko it should be fixed in the last build

@annadanchenko
Copy link

@annadanchenko it should be fixed in the last build

thanks @cammellos indeed account can be created fine on new Windows build https://ci.status.im/job/status-react/job/prs/job/windows/job/PR-7294/20/

@pedropombeiro
Copy link
Contributor Author

OK, Linux build is finally green.

@annadanchenko
Copy link

annadanchenko commented Jan 24, 2019 •
edited

Update: can reproduce in nightly, #7332
@cammellos empty error popup is shown after sending SNT to a contact from Wallet.
screenshot_20190124-110210

I'm testing on recovered account, real Android 9 device, build 25. Can also reproduce on fresh account

01-24 11:01:24.686 27506 27616 I ReactNativeJS: ***
01-24 11:01:24.686 27506 27616 I ReactNativeJS: NAME: nil
01-24 11:01:24.686 27506 27616 I ReactNativeJS: MESSAGE: "Invalid push notification payload{:from \"0x043a5583b23ed88ef030fe4636c8cf7d5bace61f928a626726dacc9f1ece90012f5cfc7a141d883a6b86254f743fc52c8343496c28152cbe2aad920b7fbaa6e2bd\", :to nil, :id \"0x6b4e146b37eab0662ce9db71ef9864b0bf657fe3497c3197cc7158349b357394\"}"
01-24 11:01:24.686 27506 27616 I ReactNativeJS: 
01-24 11:01:24.686 27506 27616 I ReactNativeJS: 
01-24 11:01:24.686 27506 27616 I ReactNativeJS: 
01-24 11:01:24.686 27506 27616 I ReactNativeJS: ***

Steps:

  1. create account, add a contact, get some ETH and SNT
  2. join #status and #testanna chats
  3. relaunch app
  4. open Wallet and send to a contact 0.08 SNT - on transaction sent screen wait for 20-30 seconds

Status.log
geth.log

@cammellos
Copy link
Member

@annadanchenko @goranjovic had the same issue possibly on develop yesterday, @goranjovic could you confirm?

@annadanchenko
Copy link

@annadanchenko @goranjovic had the same issue possibly on develop yesterday, @goranjovic could you confirm?

yes, it's in nightly too #7332

@annadanchenko annadanchenko mentioned this pull request Jan 24, 2019
Closed
@churik
Copy link
Member

churik commented Jan 24, 2019

Tested Mac OS and Linux builds - fresh install, upgrade from current nightly, creating new account, restoring account from seed phrase, everything looks fine

@annadanchenko
Copy link

annadanchenko commented Jan 24, 2019 •
edited

on iOS, see no checkbox next to device to pair with. If click on the line next to device name that "invisible" checkbox is set to ON and becomes visible

74278

@annadanchenko annadanchenko moved this from IN TESTING to MERGE in Pipeline for QA Jan 24, 2019
@cammellos cammellos force-pushed the feature/use-send-data-notification branch from 25ac147 to 99db611 Compare January 24, 2019 14:40
@cammellos
Use new status-go and rename NotifyUsers
d3f1b37 
Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
@cammellos cammellos force-pushed the feature/use-send-data-notification branch from 99db611 to d3f1b37 Compare January 24, 2019 14:41
@cammellos cammellos merged commit d3f1b37 into develop Jan 24, 2019
Pipeline for QA automation moved this from MERGE to DONE Jan 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/use-send-data-notification branch January 24, 2019 14:41
@mandrigin mandrigin mentioned this pull request Jan 24, 2019
Closed
@qfrank qfrank mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandrigin mandrigin mandrigin approved these changes

@cammellos cammellos cammellos left review comments

@rasom rasom rasom approved these changes

Assignees

@pedropombeiro pedropombeiro

@annadanchenko annadanchenko

Labels
Tested - OK
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet