Fix qr code and bootnode

[cammellos]

Fixes: #7779

Just ordering of parameters.

status: ready

[status-github-bot]

Pull Request Checklist

• Have you updated the documentation, if impacted (e.g. docs.status.im)?

[status-im-auto]

Jenkins Builds

Click to see older builds (6)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	1c2846f	#1	2019-03-21 08:15:30	~17 min	macos	📦 dmg
✔️	1c2846f	#1	2019-03-21 08:16:54	~19 min	ios	📦 ipa
✔️	1c2846f	#1	2019-03-21 08:20:06	~22 min	linux	📦 App
✔️	1c2846f	#1	2019-03-21 08:21:19	~23 min	android-e2e	📦 apk
✔️	1c2846f	#1	2019-03-21 08:23:10	~25 min	android	📦 apk
✔️	1c2846f	#1	2019-03-21 08:24:20	~26 min	windows	📦 exe

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	202b48b	#2	2019-03-21 10:07:46	~14 min	android	📦 apk
✔️	202b48b	#2	2019-03-21 10:08:37	~15 min	macos	📦 dmg
✔️	202b48b	#2	2019-03-21 10:10:23	~17 min	ios	📦 ipa
✔️	202b48b	#2	2019-03-21 10:12:18	~19 min	android-e2e	📦 apk
✔️	202b48b	#2	2019-03-21 10:13:28	~20 min	linux	📦 App
✔️	202b48b	#2	2019-03-21 10:16:23	~23 min	windows	📦 exe
✔️	25ea019	#3	2019-03-21 12:59:00	~17 min	android-e2e	📦 apk
✔️	25ea019	#3	2019-03-21 13:00:37	~19 min	android	📦 apk

[churik]

@cammellos there is no error when scanning anymore, however, "Save" button is inactive when scanning QR from https://gist.github.com/jacqueswww/3ddfc5ecfa09ecea702744ab15a2200d.
I found that it is because of two whitespaces are placed after the bootnode address.
Should it be fixed in QR code on https://gist.github.com/jacqueswww/3ddfc5ecfa09ecea702744ab15a2200d or we should trim the input, WDYT?

[cammellos]

@churik I will strip trailing whitespaces when scanning from qr, but for now only when from QR, is that ok?

[churik]

@cammellos I believe it is enough for now, agree

[cammellos]

@churik should be fixed now

[statustestbot]

98% of end-end tests have passed

Total executed tests: 46
Failed tests: 1
Passed tests: 45

Failed tests (1)

Click to expand

1. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for PlusButton Device 1: Wait for PlusButton Donation was not received during 300 seconds! Device sessions Device 1: Steps, video, logs Failure screenshot

Passed tests (45)

Click to expand

1. test_filters_from_daap

Device sessions Device 1: Steps, video, logs

2. test_copy_and_paste_messages

Device sessions Device 1: Steps, video, logs

3. test_send_transaction_from_daap

Device sessions Device 1: Steps, video, logs

4. test_request_and_receive_tokens_in_1_1_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_deploy_contract_from_daap

Device sessions Device 1: Steps, video, logs

6. test_public_chat_messaging

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

7. test_password_in_logcat_sign_in

Device sessions Device 1: Steps, video, logs

8. test_text_message_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

9. test_add_to_contacts

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_unread_messages_counter_1_1_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

11. test_logcat_send_transaction_from_daap

Device sessions Device 1: Steps, video, logs

12. test_send_message_in_group_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

13. test_logcat_send_transaction_from_wallet

Device sessions Device 1: Steps, video, logs

14. test_send_token_with_7_decimals

Device sessions Device 1: Steps, video, logs

15. test_modify_transaction_fee_values

Device sessions Device 1: Steps, video, logs

16. test_send_eth_from_wallet_to_address

Device sessions Device 1: Steps, video, logs

17. test_manage_assets

Device sessions Device 1: Steps, video, logs

18. test_logcat_send_transaction_in_1_1_chat

Device sessions Device 1: Steps, video, logs

19. test_request_and_receive_eth_in_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

20. test_swipe_to_delete_public_chat

Device sessions Device 1: Steps, video, logs

21. test_send_emoji

Device sessions Device 1: Steps, video, logs

22. test_search_chat_on_home

Device sessions Device 1: Steps, video, logs

23. test_logcat_recovering_account

Device sessions Device 1: Steps, video, logs

24. test_messaging_in_different_networks

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

25. test_send_tokens_in_1_1_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

26. test_network_mismatch_for_send_request_commands

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

27. test_logcat_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

28. test_swipe_to_delete_1_1_chat

Device sessions Device 1: Steps, video, logs

29. test_switch_users_and_add_new_account

Device sessions Device 1: Steps, video, logs

30. test_send_stt_from_wallet

Device sessions Device 1: Steps, video, logs

31. test_send_eth_in_1_1_chat

Device sessions Device 2: Steps, video, logs Device 1: Steps, video, logs

32. test_login_with_new_account

Device sessions Device 1: Steps, video, logs

33. test_send_eth_from_wallet_to_contact

Device sessions Device 1: Steps, video, logs

34. test_add_contact_from_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

35. test_send_two_transactions_one_after_another_in_dapp

Device sessions Device 1: Steps, video, logs

36. test_password_in_logcat_creating_account

Device sessions Device 1: Steps, video, logs

37. test_backup_recovery_phrase

Device sessions Device 1: Steps, video, logs

38. test_offline_status

Device sessions Device 1: Steps, video, logs

39. test_open_google_com_via_open_dapp

Device sessions Device 1: Steps, video, logs

40. test_unread_messages_counter_public_chat

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

41. test_sign_message_from_daap

Device sessions Device 1: Steps, video, logs

42. test_user_can_remove_profile_picture

Device sessions Device 1: Steps, video, logs

43. test_share_contact_code_and_wallet_address

Device sessions Device 1: Steps, video, logs

44. test_request_eth_in_wallet

Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

45. test_refresh_button_browsing_app_webview

Device sessions Device 1: Steps, video, logs

[churik]

Can save bootnode when scan valid QR, paste valid bootnode from https://gist.github.com/jacqueswww/3ddfc5ecfa09ecea702744ab15a2200d when app is offline / online and the bootnodes are disabled / enabled.
Tested on IOS 11.4.1 and Android 8.0