Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] remove web3, clean up wallet effects #8232

Closed
wants to merge 1 commit into from

Conversation

yenda
Copy link
Contributor

@yenda yenda commented May 19, 2019

  • introduce json-rpc namespace, which provides call and eth-call,
    a generic way of calling a json-rpc method taking care of conversions
    and error handling
  • remove web3 usage from wallet
  • clean up effects, reducing the amount of computations when login in

status: ready

@status-github-bot
Copy link

status-github-bot bot commented May 19, 2019

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented May 19, 2019

Jenkins Builds

Click to see older builds (24)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 92dbe1d #1 2019-05-19 20:09:02 ~17 min linux 📦 App
✔️ 92dbe1d #1 2019-05-19 20:09:50 ~18 min windows 📦 exe
✔️ 92dbe1d #1 2019-05-19 20:10:16 ~18 min android 📦 apk
✔️ 92dbe1d #1 2019-05-19 20:10:51 ~19 min macos 📦 dmg
✔️ 92dbe1d #1 2019-05-19 20:12:13 ~20 min android-e2e 📦 apk
✔️ 92dbe1d #1 2019-05-19 20:15:48 ~24 min ios 📦 ipa
✔️ 4d3e170 #2 2019-05-19 21:26:05 ~15 min linux 📦 App
✔️ 4d3e170 #2 2019-05-19 21:26:51 ~16 min windows 📦 exe
✔️ 4d3e170 #2 2019-05-19 21:30:29 ~19 min macos 📦 dmg
✔️ 4d3e170 #2 2019-05-19 21:31:18 ~20 min android 📦 apk
✔️ 4d3e170 #2 2019-05-19 21:31:22 ~20 min android-e2e 📦 apk
✔️ 4d3e170 #2 2019-05-19 21:34:06 ~23 min ios 📦 ipa
✔️ c646252 #4 2019-05-20 03:38:01 ~28 min android 📦 apk
✔️ c646252 #4 2019-05-20 03:38:47 ~29 min windows 📦 exe
✔️ c646252 #4 2019-05-20 03:38:53 ~29 min android-e2e 📦 apk
✔️ c646252 #4 2019-05-20 03:40:06 ~30 min macos 📦 dmg
✔️ c646252 #4 2019-05-20 03:42:12 ~32 min linux 📦 App
✔️ c646252 #4 2019-05-20 03:42:19 ~32 min ios 📦 ipa
948e3e7 #5 2019-05-20 13:06:24 ~11 min ios 📄 log
948e3e7 #5 2019-05-20 13:10:03 ~15 min macos 📄 log
948e3e7 #5 2019-05-20 13:21:44 ~26 min linux 📄 log
948e3e7 #5 2019-05-20 13:26:12 ~31 min windows 📄 log
948e3e7 #5 2019-05-20 13:27:34 ~32 min android-e2e 📄 log
948e3e7 #5 2019-05-20 13:29:09 ~34 min android 📄 log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1b6419b #6 2019-05-20 14:08:45 ~32 min macos 📦 dmg
✔️ 1b6419b #6 2019-05-20 14:13:16 ~37 min ios 📦 ipa
✔️ 1b6419b #6 2019-05-20 14:20:41 ~44 min android-e2e 📦 apk
✔️ 1b6419b #6 2019-05-20 14:26:38 ~50 min android 📦 apk
✔️ 1b6419b #6 2019-05-20 14:26:58 ~51 min linux 📦 App
✔️ 1b6419b #6 2019-05-20 14:27:40 ~51 min windows 📦 exe
✔️ 2c8770f #7 2019-05-20 15:43:14 ~33 min linux 📦 App
✔️ 2c8770f #7 2019-05-20 15:44:20 ~34 min android 📦 apk
✔️ 2c8770f #7 2019-05-20 15:45:28 ~35 min macos 📦 dmg
✔️ 2c8770f #7 2019-05-20 15:46:05 ~36 min android-e2e 📦 apk
✔️ 2c8770f #7 2019-05-20 15:46:48 ~36 min ios 📦 ipa
✔️ 2c8770f #7 2019-05-20 15:49:12 ~39 min windows 📦 exe

@yenda yenda force-pushed the wallet/remove-web3 branch 3 times, most recently from 18c326f to c646252 Compare May 20, 2019 03:09
@yenda yenda requested review from flexsurfer and vitvly May 20, 2019 03:10
@yenda yenda marked this pull request as ready for review May 20, 2019 03:12
@yenda yenda requested review from antdanchenko, churik and a team as code owners May 20, 2019 03:12
@yenda yenda requested review from jeluard and dmitryn May 20, 2019 12:22
#(log/error :json-rpc/error method :params params :error %))]
(if (nil? method)
(log/error :json-rpc/method-not-found method)
(status/call-private-rpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be good to have something like (status/call-private-rpc "name" params)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I made initially but it turns out you always have different options so I figured it is better to have this generic function taking a map.

@status-github-bot status-github-bot bot moved this from REVIEW to E2E Tests in Pipeline for QA May 20, 2019
@statustestbot
Copy link

17% of end-end tests have passed

Total executed tests: 12
Failed tests: 10
Passed tests: 2

Failed tests (10)

Click to expand
1. test_block_user_from_public_chat
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7fd48db90780>: Failed to establish a new connection: [Errno -3] Tempo


2. test_request_and_receive_tokens_in_1_1_chat
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7f198a4c9748>: Failed to establish a new connection: [Errno -3] Tempo


3. test_add_to_contacts

Device 1: Wait for ChatMessageInput
Device 1: Tap 'Confirm' on native keyboard

E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7f23424f27b8>: Failed to establish a new connection: [Errno -3] Tempo


Device sessions

4. test_request_and_receive_eth_in_1_1_chat
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7fcfe6327748>: Failed to establish a new connection: [Errno -3] Tempo


5. test_send_tokens_in_1_1_chat
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7f181993f8d0>: Failed to establish a new connection: [Errno -3] Tempo


6. test_network_mismatch_for_send_request_commands
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7fec3e88bf60>: Failed to establish a new connection: [Errno -3] Tempo


7. test_send_eth_in_1_1_chat
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7f2bbd571a58>: Failed to establish a new connection: [Errno -3] Tempo


8. test_add_contact_from_public_chat
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7f94be0cbac8>: Failed to establish a new connection: [Errno -3] Tempo


9. test_offline_status
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7f43663a30f0>: Failed to establish a new connection: [Errno -3] Tempo


10. test_request_eth_in_wallet
E socket.gaierror: [Errno -3] Temporary failure in name resolution

During handling of the above exception, another exception occurred:
<urllib3.connection.HTTPConnection object at 0x7f175c202710>: Failed to establish a new connection: [Errno -3] Tempo


Passed tests (2)

Click to expand
1. test_text_message_1_1_chat
Device sessions

2. test_send_emoji
Device sessions

- introduce json-rpc namespace, which provides `call` and `eth-call`,
a generic way of calling a json-rpc method taking care of conversions
and error handling
- remove web3 usage from wallet
- clean up effects, reducing the amount of computations when login in
Pipeline for QA automation moved this from E2E Tests to DONE May 20, 2019
@jakubgs jakubgs deleted the wallet/remove-web3 branch May 12, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants