-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactoring] remove web3, clean up wallet effects #8232
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (24)
|
18c326f
to
c646252
Compare
#(log/error :json-rpc/error method :params params :error %))] | ||
(if (nil? method) | ||
(log/error :json-rpc/method-not-found method) | ||
(status/call-private-rpc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to have something like (status/call-private-rpc "name" params)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what I made initially but it turns out you always have different options so I figured it is better to have this generic function taking a map.
17% of end-end tests have passed
Failed tests (10)Click to expand
Passed tests (2)Click to expand
|
- introduce json-rpc namespace, which provides `call` and `eth-call`, a generic way of calling a json-rpc method taking care of conversions and error handling - remove web3 usage from wallet - clean up effects, reducing the amount of computations when login in
call
andeth-call
,a generic way of calling a json-rpc method taking care of conversions
and error handling
status: ready