chore: introduce SNT V2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
commented
Nov 3, 2023
src/SNTTestnetController.sol
Outdated
|
|
||
| event ClaimedTokens(address indexed _token, address indexed _controller, uint256 _amount); | ||
| event ControllerChanged(address indexed _newController); | ||
| } |
There was a problem hiding this comment.
We might as well remove SNTTestnetController and extend SNTController to have an enabled property or something which would enable generateTokens(). Then we can use one controller contract for different networks.
0x-r4bbit
commented
Nov 8, 2023
| uint8 _decimalUnits, | ||
| string memory _tokenSymbol | ||
| ) | ||
| MiniMeToken(MiniMeToken(payable(address(0))), 0, _tokenName, _decimalUnits, _tokenSymbol, true) |
There was a problem hiding this comment.
I've hardcoded some of the parameters here as I don't think it's likely we'll ever want to deploy an SNT token that is not transferable or needs a parent block snapshot, or parent token.
@3esmit lemme know if you think this should be changed.
gravityblast
approved these changes
Nov 9, 2023
This introduces an SNT V2 token implementation. It inherits from `MiniMeToken` and also comes with an `SNTTestnetController` that can be used on test networks for allowing minting of tokens by anyone. This makes the token controller more general and introduces an `open` property to enable/disable the faucet. Also adds a `destroyTokens()` function for completeness' sake.
0x-r4bbit
force-pushed
the
chore/sntv2
branch
from
63196ac
to
602f791
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an SNT V2 token implementation. It inherits from
MiniMeTokenand also comes with anSNTTestnetControllerthat can be used on test networks for allowing minting of tokens by anyone.Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?pnpm lint?forge test?