Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect amount populated with QR code scan of EIP-681 #12587

Closed
hesterbruikman opened this issue Sep 15, 2021 · 4 comments
Closed

Incorrect amount populated with QR code scan of EIP-681 #12587

hesterbruikman opened this issue Sep 15, 2021 · 4 comments
Assignees
Labels
E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes

Comments

@hesterbruikman
Copy link
Contributor

Bug Report

Problem

When scanning a QR code to make a payment, wallet populated the amount with zeros. Maybe amount in Gwei? QR code was reportedly following eip-681

Expected behavior

When using QR code scanner tx input fields are populated correct and readible with data from url

Actual behavior

  • Currency > populated correctly (DAI)
  • Amount > not populated correctly. Lots of 0's looks like denomination is off/not parsed. Amount in USD looks derived from incorrectly populated token amount and now shows 275,000,000,000,000,000,000.00 USD
  • Address > unsure, cut off screenshot 😕

Screenshot_20210915-182451_Status

Reproduction

  1. Open Status
  2. Open Wallet
  3. Tap QR code scanner
  4. Scan QR code that follows eip-681 with $275 in DAI (not sure if issue occurs with other tokens)

Additional Information

  • Status version: 1.16.0 (20210827115911) afaik this is a public release
  • Operating System: Android

Can send Trace logs if needed, please ping if that helps. Didn't notice anything in particular; seems like a UI bug

@flexsurfer
Copy link
Member

how can we make sure QR code is correct ?

@hesterbruikman
Copy link
Contributor Author

I believe this using was used: https://github.com/esPass/pretix-eth-payment-plugin

I haven't checked, but I suspect it includes QR code generation

@churik
Copy link
Member

churik commented Sep 17, 2021

@hesterbruikman afaik we didn't use the amount converted in USD in QRs, I didn't check it because we don't have such option in wallet.
I've tested always with https://brunobar79.github.io/eip681-link-generator/# and I didn't see any option to add converted value to amount.
I may be wrong though, but we need QR for investigating this

@churik churik added E:Mobile Wallet MVP Design system components, initial research and page wireframes recheck labels Dec 5, 2022
@churik
Copy link
Member

churik commented Dec 5, 2022

closing due to re-design, label recheck added for future re-consideration

@churik churik closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Mobile Bug MVP E:Mobile Wallet MVP Design system components, initial research and page wireframes
Projects
None yet
Development

No branches or pull requests

3 participants