Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons offscreen for "App" would like to connect to your wallet #7215

Closed
BlinkyStitt opened this issue Jan 7, 2019 · 17 comments
Closed

Buttons offscreen for "App" would like to connect to your wallet #7215

BlinkyStitt opened this issue Jan 7, 2019 · 17 comments
Assignees
Labels

Comments

@BlinkyStitt
Copy link

BlinkyStitt commented Jan 7, 2019

Problem

When approving a new site on an iPhone XS Max, the buttons to approve/deny are pushed off the bottom of the screen.

You can see just the top of them which is barely enough to tap, but you can't read the text so you have to guess what the buttons say.

img!UNITO-UNDERSCORE!7777

@BlinkyStitt
Copy link
Author

This is even worse on the latest version. Now the bar to select “home/wallet/profile” entirely covers the deny/approve buttons. I can’t use the app anymore

@rasom
Copy link
Contributor

rasom commented Mar 1, 2019

This issue is not XS Max specific, it is rather related to Larger Text settings on iOS. It can't be reproduced with default settings.

It definitely can be much worse though
screen shot 2019-03-01 at 09 10 09

@churik churik self-assigned this Mar 5, 2019
@churik
Copy link
Member

churik commented Mar 5, 2019

Most visible on largest text on IOS 12.1 (IPhone XS) - because you can adjust it to 10 level without accessibility settings.

On IOS 11.4.1. only 7 levels are available by default, in order to reproduce it, you need to switch on accessibility mode.

@churik
Copy link
Member

churik commented Apr 4, 2019

This particular screen should be fixed here (see discussion here: #7873 (comment))

@churik
Copy link
Member

churik commented Apr 4, 2019

@mandrigin set please size for this one. Thanks!

@mandrigin
Copy link
Contributor

Done!

Note to the bounty hunters: you only need to fix the dialog that is on the initial screenshot in the issue description.

@mandrigin
Copy link
Contributor

@StatusSceptre any news on approval of this bounty?

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

@Skyge Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@Skyge
Copy link

Skyge commented Apr 21, 2019

@StatusSceptre Hi, I am so sorry for replying so late, I have got to do something private suddenly, so I will stop to do this bounty, but I have asked another bro and he will help on the bounty. @iamonuwa

@Skyge
Copy link

Skyge commented Apr 23, 2019

@StatusSceptre This is a specific task for iPhone, but iamonuwa does not have the suitable environment, so he can not do this either, so sorry. Maybe someone else will do this task, if no one find this, I will come back after 8 days, by then, I must have solved my private things.

@krisc
Copy link

krisc commented Jun 11, 2019

@Skyge still interested in this bounty?

@StatusWrike StatusWrike changed the title Buttons offscreen for "App" would like to connect to your wallet Buttons offscreen for "App" would like to connect to your wallet Jun 11, 2019
@JollyRogerz
Copy link

Has someone completed this bounty already ?

@gitcoinbot
Copy link

gitcoinbot commented Jul 18, 2019

Issue Status: 1. Open 2. Cancelled


Workers have applied to start work.

These users each claimed they can complete the work by 1 month, 3 weeks ago.
Please review their action plans below:

1) keheira has applied to start work (Funders only: approve worker | reject worker).

I would take a deeper look at where the last developer left off. I will find the dialog shown and fix the spacing so that works with all iOS screens.
2) andrewsb has applied to start work (Funders only: approve worker | reject worker).

Get setup with the react-native environment, check out how layout is performed for that modal, update the layout to take into account a smaller vertical height

Learn more on the Gitcoin Issue Details page.

@churik
Copy link
Member

churik commented Sep 3, 2019

Still reproducible (IOS 11.4.1., nightly 03/09/2019)
IMG_570017C57F92-1

@churik
Copy link
Member

churik commented Feb 25, 2020

not reproducible on nightly 25/02/2020 (IOS 13)
photo_2020-02-25 16 17 41

@churik churik closed this as completed Feb 25, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled


The funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants