Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new asset for Ethdenver event #7266

Closed
StatusSceptre opened this issue Jan 14, 2019 · 22 comments · Fixed by #7407
Closed

Add new asset for Ethdenver event #7266

StatusSceptre opened this issue Jan 14, 2019 · 22 comments · Fixed by #7407
Assignees

Comments

@StatusSceptre
Copy link
Member

StatusSceptre commented Jan 14, 2019

This is for a custom token on XDAI network

we'll need address, name, symbol and icon image should be added

For public release 0.9.34

@pablanopete
Copy link
Contributor

part of #7224 release needs.

@rachelhamlin
Copy link
Contributor

cc @goranjovic - a request for ETHDenver

@StatusSceptre
Copy link
Member Author

@austintgriffith to help update when there's more information available.

@rachelhamlin
Copy link
Contributor

Hey guys! Do you think this token will be ready by end of week? That's the safest deadline to guarantee that it makes it into the public release.

@pablanopete @austintgriffith

@dbe
Copy link

dbe commented Jan 22, 2019

Hey @rachelhamlin,

I'm working on the burner-wallet with Austin for ETH Denver. We are going to come up with a firm code freeze data asap and can update this at that point.

One quick question: Does the contract address for our token need to be hard-coded and sent out as part of a release, or is that something we could update dynamically in case there were any changes we were forced to make to the token contract. I'm trying to get a picture of how frozen the contract needs to be.

@rachelhamlin
Copy link
Contributor

Hey @dbe - unfortunately at this point, we hard code token addresses :( So there is pressure to include it in time for testing and release.

@austintgriffith
Copy link

Hey guys, we will for sure have a token contract address for you by the 30th.
We'd like to get everything we can possibly think of tested by then.
We will try to have it sooner, but there are just things we want to make sure get included.
One thing we should mention is there is a chance something new comes up that causes us to run on a new token. So the status app would be on the old token.
Is there at least a way you guys can deploy with some sort of a deadman switch in case we have to patch the contract days before the event?

@rachelhamlin
Copy link
Contributor

That's great news, @austintgriffith. Pinged @goranjovic on Status, as he's the one to answer your question. Will check back in for updates.

@goranjovic
Copy link
Contributor

Is there at least a way you guys can deploy with some sort of a deadman switch in case we have to patch the contract days before the event?

Unfortunately, no. If you change the contract, we can only re-release, which isn't a quick process.

@Swader
Copy link
Contributor

Swader commented Jan 23, 2019

@goranjovic why not use a proxy contract and then replace the implementation being referenced behind the scenes if needed?

@mandrigin
Copy link
Contributor

I agree with @Swader but I guess this question is more suitable for @austintgriffith to answer...

@austintgriffith
Copy link

Yeah we could probably set something up like that if we have time. Let me ping @dbe on this too.

@rachelhamlin
Copy link
Contributor

Apologies to be pushy about it @austintgriffith but roughly how much longer are we looking at for a contract we can use here? Does by the 30th likely = the 30th at this point?

@austintgriffith
Copy link

austintgriffith commented Feb 2, 2019

Okay, we finally got it audited, deployed, and verified:
https://blockscout.com/poa/dai/address/0x3e50bf6703fc132a94e4baff068db2055655f11b/contracts

Name: buffiDai
Symbol: BUFF
Address: 0x3e50bf6703fc132a94e4baff068db2055655f11b
Image:
bufficorn

View the account balance, transactions, and other data for 0x3E50BF6703Fc132A94E4BAfF068db2055655f11B on the (xDAI)

@austintgriffith
Copy link

Here is a new image, they wanted to float the dai logo on top:
buffidailogo

@rachelhamlin
Copy link
Contributor

Great work guys!

@austintgriffith can we get some tokens for testing? You can send to 0x06E7D699c4842E712E32d66C15F7e451c0E2a496

@guylouis
Copy link
Contributor

guylouis commented Feb 4, 2019

@goranjovic @mandrigin can we add support for this BUFF token in 0.9.33 ?

@austintgriffith
Copy link

So, anyone can buy into buffiDai. You just go to buffidai.io, click exchange, and move xDai into buffiDai:
image

Also, I sent you $0.25 in BUFF:
image

mandrigin pushed a commit that referenced this issue Feb 4, 2019
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
mandrigin pushed a commit that referenced this issue Feb 4, 2019
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
@rachelhamlin
Copy link
Contributor

rachelhamlin commented Feb 5, 2019

Nvm - I'm told tokens have changed hands :) cheers!

Hey @austintgriffith @dbe! Just a reminder - we need some test tokens to make sure things are working properly, although the token's been merged and should be included in our release.

Can you send some tokens for testing to 0x06E7D699c4842E712E32d66C15F7e451c0E2a496?

@StatusSceptre
Copy link
Member Author

Hey this has been taken care of w/ anna Out of band! Thx.

@austintgriffith
Copy link

austintgriffith commented Feb 5, 2019

@rachelhamlin it looks like that address has 0.25 BUFF. https://blockscout.com/poa/dai/address/0x06e7d699c4842e712e32d66c15f7e451c0e2a496/transactions
You can also bridge into buffidai.io in the Exchange section.
Do you guys need more tokens or did you get it solved?

View the account balance, transactions, and other data for 0x06E7D699c4842E712E32d66C15F7e451c0E2a496 on the (xDAI)

@rachelhamlin
Copy link
Contributor

All set @austintgriffith. Just overlooked that pre-coffee this morning. Thanks though!

dhamaniasad pushed a commit to dhamaniasad/status-react that referenced this issue Feb 6, 2019
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants