-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new asset for Ethdenver event #7266
Comments
part of #7224 release needs. |
cc @goranjovic - a request for ETHDenver |
@austintgriffith to help update when there's more information available. |
Hey guys! Do you think this token will be ready by end of week? That's the safest deadline to guarantee that it makes it into the public release. |
Hey @rachelhamlin, I'm working on the burner-wallet with Austin for ETH Denver. We are going to come up with a firm code freeze data asap and can update this at that point. One quick question: Does the contract address for our token need to be hard-coded and sent out as part of a release, or is that something we could update dynamically in case there were any changes we were forced to make to the token contract. I'm trying to get a picture of how frozen the contract needs to be. |
Hey @dbe - unfortunately at this point, we hard code token addresses :( So there is pressure to include it in time for testing and release. |
Hey guys, we will for sure have a token contract address for you by the 30th. |
That's great news, @austintgriffith. Pinged @goranjovic on Status, as he's the one to answer your question. Will check back in for updates. |
Unfortunately, no. If you change the contract, we can only re-release, which isn't a quick process. |
@goranjovic why not use a proxy contract and then replace the implementation being referenced behind the scenes if needed? |
I agree with @Swader but I guess this question is more suitable for @austintgriffith to answer... |
Yeah we could probably set something up like that if we have time. Let me ping @dbe on this too. |
Apologies to be pushy about it @austintgriffith but roughly how much longer are we looking at for a contract we can use here? Does by the 30th likely = the 30th at this point? |
Okay, we finally got it audited, deployed, and verified: Name: buffiDai
|
Great work guys! @austintgriffith can we get some tokens for testing? You can send to 0x06E7D699c4842E712E32d66C15F7e451c0E2a496 |
@goranjovic @mandrigin can we add support for this BUFF token in 0.9.33 ? |
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
Nvm - I'm told tokens have changed hands :) cheers! Hey @austintgriffith @dbe! Just a reminder - we need some test tokens to make sure things are working properly, although the token's been merged and should be included in our release. Can you send some tokens for testing to 0x06E7D699c4842E712E32d66C15F7e451c0E2a496? |
Hey this has been taken care of w/ anna Out of band! Thx. |
@rachelhamlin it looks like that address has 0.25 BUFF. https://blockscout.com/poa/dai/address/0x06e7d699c4842e712e32d66c15f7e451c0e2a496/transactions
|
All set @austintgriffith. Just overlooked that pre-coffee this morning. Thanks though! |
Signed-off-by: Igor Mandrigin <i@mandrigin.ru>
This is for a custom token on XDAI network
we'll need address, name, symbol and icon image should be added
For public release 0.9.34
The text was updated successfully, but these errors were encountered: