-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profile] Other profile screen UI #8071
Comments
➤ Julien Eluard commented: Estimated to 1 day of work |
@hesterbruikman @flexsurfer do we want the icon\username to be inside the toolbar? in figma seems to be inside (i can see the lightgrey separator there). @flexsurfer is toolbar planned to be replaced with something else? https://github.com/status-im/status-react/blob/de0d98da20baf9e6ece6fc3f562e6db181c50375/src/status_im/ui/components/toolbar/view.cljs#L114-L116 |
hey @tbenr, no, icon\username should be outside toolbar, we are not planning to replace toolbar in near future, so you can just use a view with 1px height for the line |
btw @hesterbruikman in profile details do we want to show user's wallet address ? @tbenr currently i think there should be only the name |
Checked the UX review notes.
So yes, the designs still include Wallet address. Reason being that Send transaction exposes the address anyway and I'd rather have this be transparent by also showing the wallet address. @andmironov can you please confirm that wallet address should be displayed in Other user's profile view for people who have added you as a contact? |
hey, let's stop there for a minute.
that's not true :) it's just a different type of toolbar. We have the regular height one, and the larger one which the profiles use. The larger one needs implementing. So @tbenr was correct, the icons and username are inside the larger toolbar. Here are the reference designs for both |
@errorists yeah but it's not in the scope of this PR for sure |
@flexsurfer sure but it's not exactly crossed out on the first mockup and it was asked :) I'm just making sure profiles are not shipped with the incorrect design. |
Can we please include the toolbar? We'll size it as a large bounty. Otherwise we accrue more design debt, which we'll then try to find another contractor for. :) Would be great to do it now if @tbenr is able and willing. |
@rachelhamlin I can work on that too. |
Hey @hesterbruikman @errorists @flexsurfer For bounties labeled as Large, I need some more info before I can assign a bounty
Can you please add this info and I'll go ahead and get the bounty approved by Finance. Thanks! |
@StatusSceptre I can answer these.
|
@flexsurfer any reason why block user is not there? do i need to strictly follow figma (where block user is at the very bottom without icon?) |
To the best of my knowledge block/unblock user should be included and is not in the above images because we hadn't realized they were missing when the images where taken to create this issue. |
thanks @tbenr updated the description, nicknames aren't in the scope |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 400.0 DAI (400.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Workers have applied to start work. These users each claimed they can complete the work by 12 months from now. 1) tbenr has applied to start work (Funders only: approve worker | reject worker). Already started working on it! Learn more on the Gitcoin Issue Details page. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 9 months, 2 weeks from now. 1) tbenr has been approved to start work. Already started working on it! Already started working on it! Learn more on the Gitcoin Issue Details page. |
@flexsurfer I don't see |
hey @tbenr , this should work (fx/defn remove-contact
{:events [:contact.ui/remove-contact-pressed]}
[{:keys [db] :as cofx}
{:keys [public-key] :as contact}]
(fx/merge cofx
{:db (update db :contacts/contacts dissoc public-key))
:data-store/tx [(contacts-store/delete-contact-tx public-key)]})) |
@gitcoinbot @StatusSceptre I submitted the bounty in gitcoin but due to ethereum congestion the tx took a couple of days to be mined. https://etherscan.io/tx/0x66184ea1c60eeb0287a1e07b7170f110d83be387895f90d7c1ecf9e1e1338ab2 |
@StatusSceptre anyone form gitcoin who can have a look? |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 400.0 DAI (400.0 USD @ $1.0/DAI) has been submitted by: @StatusSceptre please take a look at the submitted work:
|
@tbenr @StatusSceptre is fixed now, was a problem with the sync on our side. Now should be ok but feel free to ping me if something is wrong. |
⚡️ A tip worth 48.00000 DAI (48.0 USD @ $1.0/DAI) has been granted to @tbenr for this issue from @StatusSceptre. ⚡️ Nice work @tbenr! Your tip has automatically been deposited in the ETH address we have on file.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 400.0 DAI (400.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @tbenr. Additional Tips for this Bounty:
|
crossed element not in the scope of this PR
Acceptance criteria:
Figma:
https://www.figma.com/file/TNCyHKtR3sx5EL6YznFWUa4O/Profile?node-id=510%3A3116
The text was updated successfully, but these errors were encountered: