Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multicollateral DAI #9491

Closed
rachelhamlin opened this issue Nov 19, 2019 · 10 comments · Fixed by #9496
Closed

Support for multicollateral DAI #9491

rachelhamlin opened this issue Nov 19, 2019 · 10 comments · Fixed by #9496
Assignees

Comments

@rachelhamlin
Copy link
Contributor

Problem

Multi-collateral DAI launched on November 18th. Changes to the DAI token are required to support this shift.

Implementation

  • The current DAI token is now 'single collateral DAI' and should be renamed to SAI.
  • In addition to SAI, we should add the new DAI to our hardcoded token list.
  • The address for multi-collateral DAI is 0x6b175474e89094c44da98b954eedeac495271d0f
  • The image assets are found HERE

Acceptance Criteria

Status default assets list should include both DAI and SAI with the appropriate addresses & logo images.

Other wallets are representing DAI and SAI like so:
image

Notes

@acolytec3
Copy link
Contributor

Could I pick this one up?

@StatusSceptre
Copy link
Member

@acolytec3 yes please! It's a very small one (~50USD) and funded in ETH rather than DAI as I migrated our funds, but Gitcoin still supports only SAI :)

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.287 ETH (49.95 USD @ $174.05/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Nov 19, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 4 weeks from now.
Please review their action plans below:

1) acolytec3 has started work.

Will complete task according to the requirements

Learn more on the Gitcoin Issue Details page.

@acolytec3
Copy link
Contributor

acolytec3 commented Nov 19, 2019

@StatusSceptre Thanks! Got a PR going locally. Who normally creates the assets in the 1x/2x/3x PNG sizes? I took a first pass at it using GIMP and just took the DAI.png from the Maker Assets and shrunk it to 120, 80, and then 40 px across like all the other token PNGs. Will include that in the PR.

@StatusSceptre
Copy link
Member

Would @errorists or @andmironov be willing to help convert the DAI logos to our required formats? :)

@errorists
Copy link
Contributor

I am willing, always for the mysterious StatusSceptre! :)

@errorists
Copy link
Contributor

and the assets can be found here
I used this image for reference since everyone seems to do their own take on the SAI badge

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.287 ETH (50.72 USD @ $176.74/ETH) has been submitted by:

  1. @acolytec3

@StatusSceptre please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.287 ETH (48.43 USD @ $168.73/ETH) attached to this issue has been approved & issued to @acolytec3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants