-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multicollateral DAI #9491
Comments
Could I pick this one up? |
@acolytec3 yes please! It's a very small one (~50USD) and funded in ETH rather than DAI as I migrated our funds, but Gitcoin still supports only SAI :) |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.287 ETH (49.95 USD @ $174.05/ETH) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 4 weeks from now. 1) acolytec3 has started work. Will complete task according to the requirements Learn more on the Gitcoin Issue Details page. |
@StatusSceptre Thanks! Got a PR going locally. Who normally creates the assets in the 1x/2x/3x PNG sizes? I took a first pass at it using GIMP and just took the DAI.png from the Maker Assets and shrunk it to 120, 80, and then 40 px across like all the other token PNGs. Will include that in the PR. |
Would @errorists or @andmironov be willing to help convert the DAI logos to our required formats? :) |
I am willing, always for the mysterious StatusSceptre! :) |
and the assets can be found here |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.287 ETH (50.72 USD @ $176.74/ETH) has been submitted by: @StatusSceptre please take a look at the submitted work:
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 0.287 ETH (48.43 USD @ $168.73/ETH) attached to this issue has been approved & issued to @acolytec3.
|
Problem
Multi-collateral DAI launched on November 18th. Changes to the DAI token are required to support this shift.
Implementation
SAI
.SAI
, we should add the newDAI
to our hardcoded token list.DAI
is 0x6b175474e89094c44da98b954eedeac495271d0fAcceptance Criteria
Status default assets list should include both DAI and SAI with the appropriate addresses & logo images.
Other wallets are representing DAI and SAI like so:
Notes
The text was updated successfully, but these errors were encountered: