[do not merge] Test Aragon dapp #7349

rasom · 2019-01-28T08:36:37Z

No description provided.

status-github-bot · 2019-01-28T08:36:42Z

Pull Request Checklist

Have you updated the documentation, if impacted (e.g. docs.status.im)?

status-im-auto · 2019-01-28T08:51:34Z

Jenkins Builds

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`b1542ec`	#1	2019-01-28 08:51:33	~14 min	`ios-e2e`	📦 package
✔️	`b1542ec`	#1	2019-01-28 08:51:44	~14 min	`macos`	📦 package
✔️	`b1542ec`	#1	2019-01-28 08:52:10	~15 min	`ios`	📦 package
✔️	`b1542ec`	#1	2019-01-28 08:53:24	~16 min	`android`	📦 package
✔️	`b1542ec`	#1	2019-01-28 08:53:54	~17 min	`android-e2e`	📦 package
✔️	`b1542ec`	#1	2019-01-28 08:55:28	~18 min	`windows`	📦 package
✔️	`b1542ec`	#1	2019-01-28 09:00:10	~23 min	`linux`	📦 package

asemiankevich · 2019-01-28T09:52:31Z

@mandrigin cant perform any transaction, i see this screen and that is it. Tapping ENABLE does not work

rasom · 2019-01-28T10:04:31Z

@jeluard @flexsurfer any ideas?

rasom · 2019-01-28T10:24:29Z

@asemiankevich did you try it on ropsten?

rasom · 2019-01-28T10:26:52Z

works on ropsten

asemiankevich · 2019-01-28T10:28:11Z

@rasom i can open the dapp. i cant send any transaction inside.

rasom · 2019-01-28T10:46:06Z

@asemiankevich, i see

no error in console when i press "enable", not sure if that's an issue on our side

rachelhamlin · 2019-01-28T10:59:06Z

I think we should still merge the DApp listing and escalate issues to Aragon for them to look at. This way we're not blocking them. We can remove for next public release if it's still broken.

rasom · 2019-01-28T11:24:02Z

@rachelhamlin current PR shouldn't be merged because it contains staging url,
this one is to be merged #7347

The problem is that the issue still might be on our side and if we release it now we will need to make another release with fix. Would be great if someone from Aragon could check it and confirm/disprove that the issue is currently on their side.

rachelhamlin · 2019-01-28T11:43:22Z

@Serhy's test notes on https://aragon.staging.aragonpm.com/#/aracon.aragonid.eth:

In the Settings Ethereum node = rinkeby.eth.aragon.network.
Voting -> "+" -> Enter question -> tap Begin Vote -> nothing happens (same with MetaMask)
Token Manager -> top-right button -> Enter your address -> Tokens to assign set to 1 -> submitt and form hides and that's all (same with MetaMask)
Finance -> New Transfer -> ETH -> empty Dapp screen (same in MetaMask)
Finance -> New Transfer -> SNT -> ... I have SNT in my address but it shows 'You have 0 SNT available'... -> anyway in amount enter 0 -> Submit Deposit -> This transaction will perform Deposit 0 SNT on Finance screen -> tap Create Transaction -> Wallet screen appears and I Sign this transaction (NOTE: i'm with Disabled web3 permission and on Rinkeby)
If 5th item - under Mainnet then at the end it asks to connect to rinkeby.
If 5th item with web3+address permissions in enabled state -> 'Please unlock and enable your Ethereum provider'

Aragon

0xc1c4da · 2019-01-28T12:11:37Z

heads-up @izqui @luisivan @sohkai @bpierre

sohkai · 2019-01-28T15:22:45Z

src/status_im/ui/screens/browser/default_dapps.cljs

@@ -149,6 +149,10 @@
             :dapp-url    "https://3box.io/"
             :photo-path  "contacts://3box"
             :description "Create and manage your Ethereum Profile."}
+            {:name        "Aragon"
+             :dapp-url    "https://aragon.staging.aragonpm.com/#/aracon.aragonid.eth/"


We will deploy to mainnet in the next few hours, the correct URL will be https://mainnet.aragon.org.

the correct link was added in #7347

AquiGorka · 2019-01-28T15:28:37Z

In the Settings Ethereum node = rinkeby.eth.aragon.network.

The correct and full URL is: wss://rinkeby.eth.aragon.network/ws

sohkai · 2019-01-28T15:28:40Z

@rasom @rachelhamlin It looks like we might've given you the wrong organization to test with. aracon.aragonid.eth has locked down permissions where only token holders can invoke actions (create new votes, mint new tokens, withdrawl funds). The lack of response is a different bug on our part where we do a huge computation (that may span several minutes) to find a path and is not something we consider a showstopper (won't affect normal users who are accessing organizations they have control over).

I've created a different organization, https://aragon.staging.aragonpm.com/#/statustest.aragonid.eth (or statustest as the name) that has more open permissions to test with. This should solve issues 1-3; we're looking into 4 and 7.

Issue 5 is likely due to the network; do you have rinkeby SNT (and are inputting the correct token address)? Otherwise, you can play with the test tokens that are available in https://aragon.staging.aragonpm.com/#/statustest.aragonid.eth/settings.

Issue 6 is correct; our staging environment is rinkeby-only.

Issue 7 is something we're investigating but might need help with. We're using the injected ethereumBeta object, first requesting eth_requestAccounts and then web3.eth.getAccounts(). It looks like when we do ask for the account, we're not getting any back.

Aragon

jeluard · 2019-01-28T16:13:32Z

@sohkai ethereumBeta is not ready yet. You should rely on ethereum.enable() that will return you back the list of addresses.

sohkai · 2019-01-28T16:34:23Z

@jeluard Is the only difference that ethereum doesn't implement the new EIP-1193 send() calls (e.g. eth_requestAccounts)? Can we do new Web3(ethereum) and expect it to be fully functioning?

jeluard · 2019-01-28T16:55:02Z

ethereum and ethereumBeta have the same shape and use. Just beta defines some extra methods.

Just curious: where did you find reference about ethereumBeta?

jeluard · 2019-01-28T16:56:40Z

@sohkai Do you have a link we could use to test with mainnet?

flexsurfer · 2019-01-28T17:15:37Z

@jeluard Is the only difference that ethereum doesn't implement the new EIP-1193 send() calls (e.g. eth_requestAccounts)? Can we do new Web3(ethereum) and expect it to be fully functioning?

@sohkai yes you can do new Web3(ethereum) but one thing you need to do is to call
ethereum.enable() and you need to set defaultAccount like this https://github.com/status-im/snt-voting/blob/7bac3c9613e11cf13d65c8de1dec23d6669a5078/app/components/flow/wallet/ExternalWallet.js#L33

sohkai · 2019-01-28T17:26:23Z

@jeluard We heard about ethereumBeta from a development chat we had last week when we initially found out our app broke on Status. We'll switch to using just ethereum and seeing if that helps.

@flexsurfer Ahh... it could be we're not calling ethereum.enable() when you don't land and go through onboarding immediately. Investigating now. I assume "privacy mode" is enabled by default?

flexsurfer · 2019-01-28T17:29:57Z

@sohkai no, in the latest Status release it's not enabled by default, only in nightlies, and will be enabled in next release

sohkai · 2019-01-29T04:16:30Z

@jarradh @rasom @rachelhamlin @jeluard @flexsurfer

We've finished deploying to Rinkeby (rinkeby.aragon.org) and Mainnet (mainnet.aragon.org) on production. Would love to have some eyes on it and have it released as part of the next build!

Testing will depend a lot on the organizations used; we don't support creating organizations from mobile yet, so the recommended way to test is to create an organization on desktop and then switch to testing it on mobile.

jeluard · 2019-01-29T09:18:21Z

@sohkai Could you check that your changes (relying on ethereum) work as expected?

rachelhamlin · 2019-01-29T10:28:52Z

Hey @sohkai, what flow are you guys looking to demo at Aracon? We're having some issues with assigning tokens. Not sure about other demo options cc @Serhy

flexsurfer · 2019-01-29T11:19:35Z

Go to Aragon (mainnet.aragon.org) -> select Demo at bottom.
Then Finance top-right button in Dapp ->Deposit -> Select Token -> select any token from list (or type token that is in your wallet but not in the list offered by Dapp) -> Submit Deposit.

@sohkai There should be 2 transactions in a row, but only one is shown, we'll fix that in the next release, but for now, it can be fixed in a Dapp by using batch requests https://github.com/ethereum/wiki/wiki/JavaScript-API#batch-requests

GitHub
ethereum/wiki
The Ethereum Wiki. Contribute to ethereum/wiki development by creating an account on GitHub.

Serhy · 2019-01-29T11:20:00Z

It's all fine with Voting creation, can create transaction from 'Token Manager', can send ETH in Finance section.

However, there is an issue with sending tokens from Aragon -> Demo organization (https://mainnet.aragon.org/#/0x8A83D4bCE45b4C4F751f76cf565953D1E4A3BF0a ) -> Finance section

Open Status with the account having ETH and tokens (e.g. with SNT)
Open Aragon from the + -> Open Dapp -> Aragon - Open
Withing Aragon Dapp tap -> Demo organization (so it's URL is https://mainnet.aragon.org/#/0x8A83D4bCE45b4C4F751f76cf565953D1E4A3BF0a )
Top-left menu button -> Finance
Tap top-right wallet button to navigate to open New Transfer screen.
From the 'Token' list select the token with >0 balance for your account (e.g. SNT in our current steps)
Enter valid amount (less than your available amount)
Tap Submit Deposit.
'Create transaction' screen appears. You will need to sign TWO transactions further.
Tap 'Create transaction' button. Status 'Send transaction' wallet screen appears. Tap Sign transaction -> enter your password -> and tap 'Sign'
Tap 'Done' on the appeared Status transaction confirmation screen.
Actual result: Waiting for signature... screen keep staying. No second 'Send transaction' wallet screen appears.
Expected result: Second 'Send transaction' screen appears

Aragon

mandrigin · 2019-01-29T11:22:39Z

сс @rachelhamlin @jarradh ↑↑↑ this is the exact issue. I will proceed with the release anyway.

mandrigin · 2019-01-29T11:23:01Z

it can be fixed ~~server-side~~ in the DApp itself too as @flexsurfer pointed out

sohkai · 2019-01-29T11:34:47Z

@jeluard

Could you check that your changes (relying on ethereum) work as expected?

Looks to be working; haven't figured out how to enable the privacy mode but getting the account on the current TestFlight build works 👍

@rachelhamlin

Could you explain what you saw with assigning tokens? AFAIK there shouldn't be any issues, outside of syncing the state (our node seems to be quite slow this morning, even before the annoucement).

@flexsurfer @mandrigin We will likely wait for this to be fixed, but will investigate batch requests. AFAIK it shouldn't be doing much differently under the hood (is there something it declares to let a node know a transaction is part of a batch?).

jeluard · 2019-01-29T11:42:52Z

@sohkai In profile you can switch Browser privacy mode on/off

flexsurfer · 2019-01-29T12:12:03Z

@flexsurfer @mandrigin We will likely wait for this to be fixed, but will investigate batch requests. AFAIK it shouldn't be doing much differently under the hood (is there something it declares to let a node know a transaction is part of a batch?).

@sohkai it works in a different way in Status itself, and we have a bug when dapp sends transaction in the moment we show sent screen for the previous transaction, we'll fix this for sure, just if you need it asap, batch is a workaround

rasom added 2 commits January 28, 2019 10:33

[#7346] Add Aragon dapp

f6cee7f

[do not merge] Test Aragon dapp

b1542ec

rasom self-assigned this Jan 28, 2019

rasom mentioned this pull request Jan 28, 2019

[#7346] Add Aragon dapp #7347

Merged

rasom closed this Jan 28, 2019

rasom deleted the aragon-dapp-test branch January 28, 2019 13:56

sohkai reviewed Jan 28, 2019

View reviewed changes

sohkai mentioned this pull request Jan 28, 2019

fix: disable usage of ethereumBeta aragon/client#597

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[do not merge] Test Aragon dapp #7349

[do not merge] Test Aragon dapp #7349

rasom commented Jan 28, 2019

status-github-bot bot commented Jan 28, 2019

status-im-auto commented Jan 28, 2019 •

edited

Loading

asemiankevich commented Jan 28, 2019

rasom commented Jan 28, 2019

rasom commented Jan 28, 2019

rasom commented Jan 28, 2019

asemiankevich commented Jan 28, 2019

rasom commented Jan 28, 2019

rachelhamlin commented Jan 28, 2019

rasom commented Jan 28, 2019

rachelhamlin commented Jan 28, 2019 •

edited by unfurl-links bot

Loading

0xc1c4da commented Jan 28, 2019

sohkai Jan 28, 2019

rasom Jan 28, 2019

AquiGorka commented Jan 28, 2019

sohkai commented Jan 28, 2019 •

edited

Loading

jeluard commented Jan 28, 2019

sohkai commented Jan 28, 2019

jeluard commented Jan 28, 2019 •

edited

Loading

jeluard commented Jan 28, 2019

flexsurfer commented Jan 28, 2019 •

edited

Loading

sohkai commented Jan 28, 2019

flexsurfer commented Jan 28, 2019

sohkai commented Jan 29, 2019

jeluard commented Jan 29, 2019

rachelhamlin commented Jan 29, 2019

flexsurfer commented Jan 29, 2019 •

edited by unfurl-links bot

Loading

Serhy commented Jan 29, 2019 •

edited by unfurl-links bot

Loading

mandrigin commented Jan 29, 2019

mandrigin commented Jan 29, 2019 •

edited

Loading

sohkai commented Jan 29, 2019

jeluard commented Jan 29, 2019

flexsurfer commented Jan 29, 2019

[do not merge] Test Aragon dapp #7349

[do not merge] Test Aragon dapp #7349

Conversation

rasom commented Jan 28, 2019

status-github-bot bot commented Jan 28, 2019

Pull Request Checklist

status-im-auto commented Jan 28, 2019 • edited Loading

Jenkins Builds

asemiankevich commented Jan 28, 2019

rasom commented Jan 28, 2019

rasom commented Jan 28, 2019

rasom commented Jan 28, 2019

asemiankevich commented Jan 28, 2019

rasom commented Jan 28, 2019

rachelhamlin commented Jan 28, 2019

rasom commented Jan 28, 2019

rachelhamlin commented Jan 28, 2019 • edited by unfurl-links bot Loading

0xc1c4da commented Jan 28, 2019

sohkai Jan 28, 2019

Choose a reason for hiding this comment

rasom Jan 28, 2019

Choose a reason for hiding this comment

AquiGorka commented Jan 28, 2019

sohkai commented Jan 28, 2019 • edited Loading

jeluard commented Jan 28, 2019

sohkai commented Jan 28, 2019

jeluard commented Jan 28, 2019 • edited Loading

jeluard commented Jan 28, 2019

flexsurfer commented Jan 28, 2019 • edited Loading

sohkai commented Jan 28, 2019

flexsurfer commented Jan 28, 2019

sohkai commented Jan 29, 2019

jeluard commented Jan 29, 2019

rachelhamlin commented Jan 29, 2019

flexsurfer commented Jan 29, 2019 • edited by unfurl-links bot Loading

Serhy commented Jan 29, 2019 • edited by unfurl-links bot Loading

mandrigin commented Jan 29, 2019

mandrigin commented Jan 29, 2019 • edited Loading

sohkai commented Jan 29, 2019

jeluard commented Jan 29, 2019

flexsurfer commented Jan 29, 2019

status-im-auto commented Jan 28, 2019 •

edited

Loading

rachelhamlin commented Jan 28, 2019 •

edited by unfurl-links bot

Loading

sohkai commented Jan 28, 2019 •

edited

Loading

jeluard commented Jan 28, 2019 •

edited

Loading

flexsurfer commented Jan 28, 2019 •

edited

Loading

flexsurfer commented Jan 29, 2019 •

edited by unfurl-links bot

Loading

Serhy commented Jan 29, 2019 •

edited by unfurl-links bot

Loading

mandrigin commented Jan 29, 2019 •

edited

Loading