Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7848] Fix crash on logout with opened transactions details #8101

Merged
merged 1 commit into from
May 2, 2019
Merged

[#7848] Fix crash on logout with opened transactions details #8101

merged 1 commit into from
May 2, 2019

Conversation

rasom
Copy link
Contributor

@rasom rasom commented May 1, 2019 •
edited by 0xc1c4da
Loading

fix #7848

status: ready

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@rasom rasom requested review from jeluard and flexsurfer May 1, 2019 18:00
@status-im-auto
Copy link
Member

status-im-auto commented May 1, 2019 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7293c99 #1 2019-05-01 18:13:52 ~13 min macos 📦 dmg
✔️ 7293c99 #1 2019-05-01 18:14:10 ~13 min linux 📦 App
✔️ 7293c99 #1 2019-05-01 18:18:31 ~18 min windows 📦 exe
✔️ 7293c99 #1 2019-05-01 18:19:44 ~19 min android-e2e 📦 apk
✔️ 7293c99 #1 2019-05-01 18:23:16 ~23 min ios 📦 ipa
✔️ 7293c99 #2 2019-05-02 09:48:41 ~20 min android 📦 apk
✔️ 62e94ed #2 2019-05-02 11:21:40 ~14 min macos 📦 dmg
✔️ 62e94ed #2 2019-05-02 11:25:08 ~17 min windows 📦 exe
✔️ 62e94ed #3 2019-05-02 11:25:11 ~17 min android 📦 apk
✔️ 62e94ed #2 2019-05-02 11:32:14 ~24 min linux 📦 App
✔️ 62e94ed #2 2019-05-02 11:33:08 ~25 min android-e2e 📦 apk

@rasom rasom self-assigned this May 1, 2019
flexsurfer
flexsurfer approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@flexsurfer flexsurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we start having such issues?

@rasom
Copy link
Contributor Author

rasom commented May 2, 2019 •
edited
Loading

@flexsurfer because screens are still rendered when we switch to another tab. And if screen gets broken state before it is unmounted we get such exceptions.

@churik churik self-assigned this May 2, 2019
@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Passed tests: 47

Failed tests (1)

Click to expand
1. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for SendTransactionButton
Device 1: Wait for BackupRecoveryPhrase

'Backup your Recovery phrase' option is not shown on Wallet for an account with funds

Device sessions

Passed tests (47)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_add_to_contacts
Device sessions

11. test_sign_typed_message (TestRail link is not found)
Device sessions

12. test_unread_messages_counter_1_1_chat
Device sessions

13. test_logcat_send_transaction_from_daap
Device sessions

14. test_send_message_in_group_chat
Device sessions

15. test_logcat_send_transaction_from_wallet
Device sessions

16. test_send_token_with_7_decimals
Device sessions

17. test_modify_transaction_fee_values
Device sessions

18. test_send_eth_from_wallet_to_address
Device sessions

19. test_manage_assets
Device sessions

20. test_logcat_send_transaction_in_1_1_chat
Device sessions

21. test_request_and_receive_eth_in_1_1_chat
Device sessions

22. test_swipe_to_delete_public_chat
Device sessions

23. test_send_emoji
Device sessions

24. test_search_chat_on_home
Device sessions

25. test_logcat_recovering_account
Device sessions

26. test_messaging_in_different_networks
Device sessions

27. test_send_tokens_in_1_1_chat
Device sessions

28. test_network_mismatch_for_send_request_commands
Device sessions

29. test_logcat_sign_message_from_daap
Device sessions

30. test_swipe_to_delete_1_1_chat
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_backup_recovery_phrase
Device sessions

40. test_offline_status
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

@status-im status-im deleted a comment from statustestbot May 2, 2019
@churik
Copy link
Member

churik commented May 2, 2019

Tested on IOS 11.4.1 (IPhone 7), Android 8 (LG V20):

  • issue is fixed
  • exploratory tesing with forсe logout (i.e. switching bootnode) and just log out when diffrent screens of wallet are shown, i.e. Send Transaction, Request Transaction, Manage assets

E2E failure is not related to this PR.

@rasom rasom force-pushed the fix/#7848-crash-on-logout branch from 7293c99 to 62e94ed Compare May 2, 2019 11:07
@rasom rasom merged commit 62e94ed into develop May 2, 2019
@status-im-auto
Copy link
Member

✔️ status-react/prs/ios/PR-8101#2 🔹 ~22 min 🔹 62e94ed 🔹 📦 ios package

@rasom rasom deleted the fix/#7848-crash-on-logout branch December 2, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeluard jeluard jeluard approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees

@churik churik

Labels
Tested - OK
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crash when changing network while Wallet tab displays Transaction Details
6 participants
@rasom @status-im-auto @statustestbot @churik @jeluard @flexsurfer