Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix #8375] "save password" unavailable for non bioauth devices #8379

Merged
merged 1 commit into from Jun 11, 2019
Merged

[fix #8375] "save password" unavailable for non bioauth devices #8379

merged 1 commit into from Jun 11, 2019

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Jun 7, 2019 •
edited by StatusWrike

fixes #8375

I forgot to remove biometric availability check on an-save-user-password? function.

fixed also :supported-biometric-auth in :db to be always nil when bioauth not supported (as per specs)

status: ready to test

@tbenr tbenr requested a review from a team as a code owner June 7, 2019 14:54
@status-github-bot
Copy link

status-github-bot bot commented Jun 7, 2019 •
edited by mandrigin

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jun 7, 2019
@tbenr tbenr changed the title [fix #8375] unavailable for non bioauth devices [fix #8375] "save password" unavailable for non bioauth devices Jun 7, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jun 7, 2019 •
edited

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ c3b8928 #1 2019-06-07 15:08:26 ~13 min windows 📄 log
✔️ c3b8928 #1 2019-06-07 15:09:53 ~15 min ios 📦 ipa
✔️ c3b8928 #1 2019-06-07 15:12:06 ~17 min linux 📦 App
✔️ c3b8928 #1 2019-06-07 15:12:21 ~17 min macos 📦 dmg
✔️ c3b8928 #1 2019-06-07 15:15:01 ~20 min android 📦 apk
✔️ c3b8928 #1 2019-06-07 15:15:04 ~20 min android-e2e 📦 apk
✔️ 39125c8 #2 2019-06-08 10:47:24 ~12 min android-e2e 📦 apk
✔️ 39125c8 #2 2019-06-08 10:47:50 ~13 min android 📦 apk
✔️ 39125c8 #2 2019-06-08 10:49:07 ~14 min ios 📦 ipa
✔️ 39125c8 #2 2019-06-08 10:51:21 ~16 min macos 📦 dmg
✔️ 39125c8 #2 2019-06-08 10:52:24 ~17 min linux 📦 App
✔️ 39125c8 #2 2019-06-08 10:53:51 ~18 min windows 📦 exe

@flexsurfer flexsurfer requested a review from mandrigin June 7, 2019 16:15
@flexsurfer flexsurfer moved this from REVIEW to E2E Tests in Pipeline for QA Jun 7, 2019
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 49
Failed tests: 0
Passed tests: 49

Passed tests (49)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_long_press_to_delete_1_1_chat
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_text_message_1_1_chat
Device sessions

12. test_add_to_contacts
Device sessions

13. test_sign_typed_message (TestRail link is not found)
Device sessions

14. test_unread_messages_counter_1_1_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_manage_assets
Device sessions

22. test_logcat_send_transaction_in_1_1_chat
Device sessions

23. test_request_and_receive_eth_in_1_1_chat
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_messaging_in_different_networks
Device sessions

29. test_send_tokens_in_1_1_chat
Device sessions

30. test_network_mismatch_for_send_request_commands
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_login_with_new_account
Device sessions

36. test_send_eth_from_wallet_to_contact
Device sessions

37. test_add_contact_from_public_chat
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_password_in_logcat_creating_account
Device sessions

40. test_backup_recovery_phrase
Device sessions

41. test_offline_status
Device sessions

42. test_open_google_com_via_open_dapp
Device sessions

43. test_unread_messages_counter_public_chat
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_user_can_remove_profile_picture
Device sessions

46. test_share_contact_code_and_wallet_address
Device sessions

47. test_request_eth_in_wallet
Device sessions

48. test_refresh_button_browsing_app_webview
Device sessions

49. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@tbenr tbenr force-pushed the save-password-not-available branch from c3b8928 to 39125c8 Compare June 8, 2019 10:34
@tbenr
Copy link
Contributor Author

tbenr commented Jun 8, 2019

removed require no more ... required

@weekly-digest weekly-digest bot mentioned this pull request Jun 9, 2019
Closed
@Serhy Serhy moved this from E2E Tests to TO TEST in Pipeline for QA Jun 10, 2019
@Serhy Serhy moved this from TO TEST to IN TESTING in Pipeline for QA Jun 10, 2019
@Serhy Serhy self-assigned this Jun 10, 2019
@Serhy
Copy link
Contributor

Serhy commented Jun 10, 2019

Looks good to me, @tbenr !

  • On Android device where I lost ability to save password - I can save it fine.
  • On iOS with bio auth feature everything kept on place as before: can use bio-auth, can disable it and proceed with login in to account via password enter.
  • With rooted Android no way to use autologin, bio-auth disabled as well.

@Serhy Serhy moved this from IN TESTING to MERGE in Pipeline for QA Jun 10, 2019
@tbenr @flexsurfer
[fix status-im#8375] unavailable for non bioauth devices
66dafae 
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit 66dafae into status-im:develop Jun 11, 2019
Pipeline for QA automation moved this from MERGE to DONE Jun 11, 2019
@tbenr tbenr deleted the save-password-not-available branch June 11, 2019 07:35
@weekly-digest weekly-digest bot mentioned this pull request Jun 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandrigin mandrigin mandrigin approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

Assignees
No one assigned
Labels
Tested - OK
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Save password" is unavailable for devices without biometric authentication
6 participants
@tbenr @status-im-auto @statustestbot @Serhy @mandrigin @flexsurfer