Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiaccount wallet screen e2e test fixes #8450

Merged
merged 1 commit into from Jun 25, 2019
Merged

Multiaccount wallet screen e2e test fixes #8450

merged 1 commit into from Jun 25, 2019

Conversation

Serhy
Copy link
Contributor

@Serhy Serhy commented Jun 20, 2019 •
edited by StatusWrike

  • added accessibility ids
  • navigation to main wallet screen and all critical e2e has been adapted to use new wallet view

Status: ready

@Serhy Serhy requested review from antdanchenko, churik and a team as code owners June 20, 2019 17:06
@Serhy Serhy self-assigned this Jun 20, 2019
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Jun 20, 2019
@status-im-auto
Copy link
Member

status-im-auto commented Jun 20, 2019 •
edited

Jenkins Builds

Click to see older builds (18)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 00352b7 #1 2019-06-20 17:19:42 ~12 min ios 📦 ipa
✔️ 00352b7 #1 2019-06-20 17:20:21 ~13 min linux 📦 App
✔️ 00352b7 #1 2019-06-20 17:20:55 ~14 min macos 📦 dmg
✔️ 00352b7 #1 2019-06-20 17:21:39 ~14 min windows 📦 exe
✔️ 00352b7 #1 2019-06-20 17:25:10 ~18 min android 📦 apk
✔️ 00352b7 #1 2019-06-20 17:25:19 ~18 min android-e2e 📦 apk
✔️ 648c8a4 #2 2019-06-21 18:08:56 ~12 min linux 📦 App
✔️ 648c8a4 #2 2019-06-21 18:09:16 ~13 min ios 📦 ipa
✔️ 648c8a4 #2 2019-06-21 18:09:51 ~13 min windows 📦 exe
✔️ 648c8a4 #2 2019-06-21 18:12:36 ~16 min macos 📦 dmg
✔️ 648c8a4 #2 2019-06-21 18:13:45 ~17 min android 📦 apk
✔️ 648c8a4 #2 2019-06-21 18:13:56 ~17 min android-e2e 📦 apk
✔️ 2afc779 #3 2019-06-24 14:36:40 ~11 min ios 📦 ipa
✔️ 2afc779 #3 2019-06-24 14:37:15 ~11 min android 📦 apk
✔️ 2afc779 #3 2019-06-24 14:38:58 ~13 min android-e2e 📦 apk
✔️ 2afc779 #3 2019-06-24 14:40:33 ~15 min macos 📦 dmg
✔️ 2afc779 #3 2019-06-24 14:43:14 ~17 min windows 📦 exe
✔️ 2afc779 #3 2019-06-24 14:45:50 ~20 min linux 📦 App
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 409550f #4 2019-06-24 16:07:27 ~12 min ios 📦 ipa
✔️ 409550f #4 2019-06-24 16:08:37 ~13 min macos 📦 dmg
✔️ 409550f #4 2019-06-24 16:10:23 ~15 min android 📦 apk
✔️ 409550f #4 2019-06-24 16:10:38 ~15 min android-e2e 📦 apk
✔️ 409550f #4 2019-06-24 16:12:29 ~17 min linux 📦 App
✔️ 409550f #4 2019-06-24 16:14:12 ~19 min windows 📦 exe
✔️ 7237dd5 #5 2019-06-25 10:56:31 ~13 min android-e2e 📦 apk

@weekly-digest weekly-digest bot mentioned this pull request Jun 23, 2019
Closed
@statustestbot
Copy link

73% of end-end tests have passed

Total executed tests: 48
Failed tests: 13
Passed tests: 35

Failed tests (13)

Click to expand
1. test_request_and_receive_tokens_in_1_1_chat

Device 2: Tap on WalletButton
Device 2: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

2. test_open_transaction_on_etherscan

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

3. test_add_to_contacts

Device 2: Tap on CrossIcon
Device 2: Tap on EditButton

Device 2: 'EditPictureButton' is not found on the screen

Device sessions

4. test_manage_assets

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

5. test_logcat_send_transaction_in_1_1_chat

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

6. test_request_and_receive_eth_in_1_1_chat

Device 2: Tap on WalletButton
Device 2: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

7. test_search_chat_on_home

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Device 1: 'SearchChatInput' is not found on the screen

Device sessions

8. test_send_tokens_in_1_1_chat

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

9. test_network_mismatch_for_send_request_commands

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

10. test_user_can_remove_profile_picture

Device 1: Wait for ShareMyProfileButton
Device 1: Tap on EditButton

Device 1: 'EditPictureButton' is not found on the screen

Device sessions

11. test_share_contact_code_and_wallet_address

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

12. test_request_eth_in_wallet

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

13. test_backup_recovery_phrase_warning_from_wallet

Device 1: Tap on WalletButton
Device 1: Wait for AccountsMoreOptions

Device 1: 'SetUpButton' is not found on the screen

Device sessions

Passed tests (35)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_long_press_to_delete_1_1_chat
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_sign_typed_message (TestRail link is not found)
Device sessions

11. test_unread_messages_counter_1_1_chat
Device sessions

12. test_logcat_send_transaction_from_daap
Device sessions

13. test_send_message_in_group_chat
Device sessions

14. test_logcat_send_transaction_from_wallet
Device sessions

15. test_send_token_with_7_decimals
Device sessions

16. test_modify_transaction_fee_values
Device sessions

17. test_send_eth_from_wallet_to_address
Device sessions

18. test_long_press_to_delete_public_chat
Device sessions

19. test_send_emoji
Device sessions

20. test_logcat_recovering_account
Device sessions

21. test_messaging_in_different_networks
Device sessions

22. test_logcat_sign_message_from_daap
Device sessions

23. test_switch_users_and_add_new_account
Device sessions

24. test_send_stt_from_wallet
Device sessions

25. test_login_with_new_account
Device sessions

26. test_send_eth_from_wallet_to_contact
Device sessions

27. test_add_contact_from_public_chat
Device sessions

28. test_send_two_transactions_one_after_another_in_dapp
Device sessions

29. test_password_in_logcat_creating_account
Device sessions

30. test_backup_recovery_phrase
Device sessions

31. test_offline_status
Device sessions

32. test_open_google_com_via_open_dapp
Device sessions

33. test_unread_messages_counter_public_chat
Device sessions

34. test_sign_message_from_daap
Device sessions

35. test_refresh_button_browsing_app_webview
Device sessions

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 49
Failed tests: 0
Passed tests: 49

Passed tests (49)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_long_press_to_delete_1_1_chat
Device sessions

10. test_password_in_logcat_sign_in
Device sessions

11. test_text_message_1_1_chat
Device sessions

12. test_add_to_contacts
Device sessions

13. test_sign_typed_message (TestRail link is not found)
Device sessions

14. test_unread_messages_counter_1_1_chat
Device sessions

15. test_logcat_send_transaction_from_daap
Device sessions

16. test_send_message_in_group_chat
Device sessions

17. test_logcat_send_transaction_from_wallet
Device sessions

18. test_send_token_with_7_decimals
Device sessions

19. test_modify_transaction_fee_values
Device sessions

20. test_send_eth_from_wallet_to_address
Device sessions

21. test_manage_assets
Device sessions

22. test_logcat_send_transaction_in_1_1_chat
Device sessions

23. test_request_and_receive_eth_in_1_1_chat
Device sessions

24. test_long_press_to_delete_public_chat
Device sessions

25. test_send_emoji
Device sessions

26. test_search_chat_on_home
Device sessions

27. test_logcat_recovering_account
Device sessions

28. test_messaging_in_different_networks
Device sessions

29. test_send_tokens_in_1_1_chat
Device sessions

30. test_network_mismatch_for_send_request_commands
Device sessions

31. test_logcat_sign_message_from_daap
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_login_with_new_account
Device sessions

36. test_send_eth_from_wallet_to_contact
Device sessions

37. test_add_contact_from_public_chat
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_password_in_logcat_creating_account
Device sessions

40. test_backup_recovery_phrase
Device sessions

41. test_offline_status
Device sessions

42. test_open_google_com_via_open_dapp
Device sessions

43. test_unread_messages_counter_public_chat
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_user_can_remove_profile_picture
Device sessions

46. test_share_contact_code_and_wallet_address
Device sessions

47. test_request_eth_in_wallet
Device sessions

48. test_refresh_button_browsing_app_webview
Device sessions

49. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@Serhy Serhy force-pushed the tests/multiaccount-wallet-e2e-fix branch from 2afc779 to 409550f Compare June 24, 2019 15:54
@Serhy Serhy changed the title [WIP] Multiaccount wallet screen e2e test fix Multiaccount wallet screen e2e test fixes Jun 24, 2019
@Serhy Serhy moved this from REVIEW to E2E Tests in Pipeline for QA Jun 25, 2019
@statustestbot
Copy link

60% of end-end tests have passed

Total executed tests: 47
Failed tests: 19
Passed tests: 28

Failed tests (19)

Click to expand
1. test_request_and_receive_tokens_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

2. test_open_transaction_on_etherscan

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

3. test_add_to_contacts

Device 2: Tap on CrossIcon
Device 2: Tap on EditButton

Device 2: 'EditPictureButton' is not found on the screen

Device sessions

4. test_logcat_send_transaction_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

5. test_send_token_with_7_decimals

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

6. test_send_eth_from_wallet_to_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

7. test_manage_assets

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

8. test_logcat_send_transaction_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

9. test_request_and_receive_eth_in_1_1_chat

Device 2: Wait for SetUpButton
Device 2: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

10. test_search_chat_on_home

Device 1: Wait for PlusButton
Device 1: Wait for PlusButton

Device 1: 'SearchChatInput' is not found on the screen

Device sessions

11. test_send_tokens_in_1_1_chat

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

12. test_network_mismatch_for_send_request_commands

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

13. test_send_stt_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

14. test_send_eth_from_wallet_to_contact

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

15. test_offline_status

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'home_button'

Device sessions

16. test_user_can_remove_profile_picture

Device 1: Wait for ShareMyProfileButton
Device 1: Tap on EditButton

Device 1: 'EditPictureButton' is not found on the screen

Device sessions

17. test_share_contact_code_and_wallet_address

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

18. test_request_eth_in_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

19. test_backup_recovery_phrase_warning_from_wallet

Device 1: Wait for SetUpButton
Device 1: Wait for SendTransactionButton

'NoneType' object has no attribute 'set_up_wallet'

Device sessions

Passed tests (28)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_public_chat_messaging
Device sessions

7. test_long_press_to_delete_1_1_chat
Device sessions

8. test_password_in_logcat_sign_in
Device sessions

9. test_text_message_1_1_chat
Device sessions

10. test_sign_typed_message (TestRail link is not found)
Device sessions

11. test_unread_messages_counter_1_1_chat
Device sessions

12. test_logcat_send_transaction_from_daap
Device sessions

13. test_send_message_in_group_chat
Device sessions

14. test_long_press_to_delete_public_chat
Device sessions

15. test_send_emoji
Device sessions

16. test_logcat_recovering_account
Device sessions

17. test_messaging_in_different_networks
Device sessions

18. test_logcat_sign_message_from_daap
Device sessions

19. test_switch_users_and_add_new_account
Device sessions

20. test_login_with_new_account
Device sessions

21. test_add_contact_from_public_chat
Device sessions

22. test_send_two_transactions_one_after_another_in_dapp
Device sessions

23. test_password_in_logcat_creating_account
Device sessions

24. test_backup_recovery_phrase
Device sessions

25. test_open_google_com_via_open_dapp
Device sessions

26. test_unread_messages_counter_public_chat
Device sessions

27. test_sign_message_from_daap
Device sessions

28. test_refresh_button_browsing_app_webview
Device sessions

@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 49
Failed tests: 1
Passed tests: 48

Failed tests (1)

Click to expand
1. test_block_user_from_public_chat

Device 1: Tap on SignInButton
Device 1: Tap on PlusButton

Device 1: 'JoinPublicChatButton' is not found on the screen

Device sessions

Passed tests (48)

Click to expand
1. test_filters_from_daap
Device sessions

2. test_copy_and_paste_messages
Device sessions

3. test_send_transaction_from_daap
Device sessions

4. test_request_and_receive_tokens_in_1_1_chat
Device sessions

5. test_deploy_contract_from_daap
Device sessions

6. test_open_transaction_on_etherscan
Device sessions

7. test_public_chat_messaging
Device sessions

8. test_long_press_to_delete_1_1_chat
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message (TestRail link is not found)
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_manage_assets
Device sessions

21. test_logcat_send_transaction_in_1_1_chat
Device sessions

22. test_request_and_receive_eth_in_1_1_chat
Device sessions

23. test_long_press_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_send_tokens_in_1_1_chat
Device sessions

29. test_network_mismatch_for_send_request_commands
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_switch_users_and_add_new_account
Device sessions

32. test_send_stt_from_wallet
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_backup_recovery_phrase
Device sessions

40. test_offline_status
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

48. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_block_user_from_public_chat
Device sessions

@Serhy Serhy moved this from E2E Tests to IN TESTING in Pipeline for QA Jun 25, 2019
@Serhy Serhy moved this from IN TESTING to MERGE in Pipeline for QA Jun 25, 2019
Multiaccount critical e2e fixed
7237dd5 
Signed-off-by: Serhy <sergii@status.im>
@Serhy Serhy force-pushed the tests/multiaccount-wallet-e2e-fix branch from 409550f to 7237dd5 Compare June 25, 2019 10:42
@Serhy Serhy merged commit 7237dd5 into develop Jun 25, 2019
Pipeline for QA automation moved this from MERGE to DONE Jun 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the tests/multiaccount-wallet-e2e-fix branch June 25, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@churik churik churik approved these changes

@asemiankevich asemiankevich asemiankevich approved these changes

@antdanchenko antdanchenko Awaiting requested review from antdanchenko

@mandrigin mandrigin Awaiting requested review from mandrigin

Assignees
No one assigned
Labels
None yet
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Serhy @status-im-auto @statustestbot @churik @asemiankevich