Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize handling of token owner waku messages #557

Merged
merged 2 commits into from
May 9, 2024

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented May 9, 2024

note: depends on #556

note: from ~13s to ~4s

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 7c1c2a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 9, 2024

@felicio is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@felicio felicio requested review from a team, jkbktl, prichodko and marcelines May 9, 2024 06:22
Copy link
Collaborator

@prichodko prichodko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does removing the check make such a huge difference? :O

What about here:

if (isEncrypted(decodedCommunityDescription.tokenPermissions)) {

?

@felicio
Copy link
Collaborator Author

felicio commented May 9, 2024

How does removing the check make such a huge difference? :O

Technically these types of messages are published for members (i.e. is encrypted) and non-members/not requiring membership (i.e. unencrypted). However, majority of these updates come for non-members which the now deleted condition would skip and instead would spend time on looking for more.

What about here:

What do you mean? Isn't it deleted right there? What am I missing?

@felicio felicio merged commit 4106248 into status-im:main May 9, 2024
2 of 4 checks passed
@felicio felicio self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants