Skip to content
This repository has been archived by the owner on Jun 13, 2022. It is now read-only.

Try to fix bug #184 #208

Merged
merged 3 commits into from
May 10, 2019
Merged

Try to fix bug #184 #208

merged 3 commits into from
May 10, 2019

Conversation

asrob
Copy link

@asrob asrob commented May 10, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ghost
Copy link

ghost commented May 10, 2019

There were the following issues with this Pull Request

  • Commit: c2502ac
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 6c03e0a
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@juliomrqz juliomrqz merged commit 6e7d26e into juliomrqz:develop May 10, 2019
@juliomrqz
Copy link
Owner

Thank you, @asrob 👍 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants