Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8 support #19

Merged
merged 11 commits into from
Nov 25, 2020
Merged

Add php 8 support #19

merged 11 commits into from
Nov 25, 2020

Conversation

chris-doehring
Copy link
Contributor

This PR adds support for php 8.

@chris-doehring
Copy link
Contributor Author

I was finally able to solve most of the CI issues, but there is still a compatibility problem with the pdo_sqlsrv extension under php 8 and shivammathur/setup-php@v2. The extension is installed, but not loaded. See further details here

@chris-doehring
Copy link
Contributor Author

All problems solved, this PR is ready for review now :)

@chris-doehring chris-doehring marked this pull request as ready for review November 24, 2020 22:05
@staudenmeir staudenmeir merged commit d805af2 into staudenmeir:master Nov 25, 2020
@staudenmeir
Copy link
Owner

Thanks! I've released a new version.

@chris-doehring chris-doehring deleted the feature/php8 branch November 25, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants