Update to skip uploading all files if any of the files fail #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stavro Is there any blocker to merge this? Also, noticed there are a lot of open PRs - do you need any help maintaining this? |
|
@stavro Is there any blocker to merge this? |
|
Looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently ran into an issue where we had multiple versions of a file and if one of the conversions fails (for example, if it is not actually an image, but a text file with an incorrect file extension) then some of the uploads will work (those which have no
:noaction) but all the conversions will fail.This results in overwriting
:originalversions despite returning an error code to the user, resulting in inconsistent states and unexpected side effects.This PR adds a test for this behavior, and updates to run the processing of files separately from the uploading so that we may stop uploads if any of the conversions fail.