Add delete_attachments to schema #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DummyDefinition being in the same file than schema test caused mock library to fail in some cases (as it documentation says, because of the way mock overrides the module, it must be defined in a separate file from the test file). That's why definition module was declared in setup for each test, causing some warnings that are gone now.
|
I could use this. @stavro wdyt? |
|
|
||
| def delete_attachments(changeset_or_data, fields) do | ||
| scope = case changeset_or_data do | ||
| %Ecto.Changeset{} -> Ecto.Changeset.apply_changes(changeset_or_data) |
There was a problem hiding this comment.
This scenario works for removing attachment with parent entity. But what if we will add the third case?
When field has changes we could remove attachment from S3 because field would be updated with new attachment without removing parent entity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
delete_attachmentsto easily delete file contents when deleting schema data using changesets. Readme file has been updated with an example.Some changes have been made to tests because of some problems with mocks. I was trying not to change them too much. But here are (commented in commit): DummyDefinition being in the same file than schema test caused mock library to fail in some cases (as it documentation says, because of the way mock overrides the module, it must be defined in a separate file from the test file). That's why definition module was declared in setup for each test, causing some warnings that are gone now.
Just tell me if you need something more. Thanks for the library!