Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when command does not exist #26

Closed
Stavrospanakakis opened this issue May 1, 2024 · 0 comments · Fixed by #27
Closed

Panic when command does not exist #26

Stavrospanakakis opened this issue May 1, 2024 · 0 comments · Fixed by #27
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Stavrospanakakis
Copy link
Owner

To Reproduce
Steps to reproduce the behavior:

  1. Run is_ready with a command that does not exist. For example:
is_ready --addr google.com:80 -- command_that_does_not_exist
  1. It will panic:
Connected to google.com:80 successfully
thread 'main' panicked at is_ready/src/lib.rs:73:10:
Failed to run the command.: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
In this case, it should handle the error and return something more user friendly such as Command not found

@Stavrospanakakis Stavrospanakakis added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant