Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balancer::isStable is not true. Need timeout or other.... #30

Closed
njozsef opened this issue Jul 13, 2014 · 2 comments
Closed

Balancer::isStable is not true. Need timeout or other.... #30

njozsef opened this issue Jul 13, 2014 · 2 comments

Comments

@njozsef
Copy link
Contributor

njozsef commented Jul 13, 2014

Hi Pawel

I testing the 200W charger is maximal current (10A).
After up the 10A constantly 'm' character is displayed. Not B or other.
therefore not balancing.
m 1:3.900V
2:3.901V3:3.902V

If reduced the 9900mA is OK. 'm' is flashing.

please help me.
I think is good the timeout or other method.

Interest:
this situation each charging-mode

charging and charging and balance.

THX
Best regards
Jozsef

bool Balancer::isStable(const uint16_t stableCount)
{
for(uint8_t c = 0; c < cells_; c++) {
if(AnalogInputs::getStableCount(AnalogInputs::Name(AnalogInputs::Vb1+c)) < stableCount)
return false;
}
return true;
}

@stawel
Copy link
Owner

stawel commented Jul 13, 2014

"m 1:3.900V"
"2:3.901V3:3.902V"
hm.. if the difference between "max" and "min" voltage is < 8mV (or "options"->"settings"->"bal. err")
no balancing is performed, in your case it's 3.902V-3.900V = 2mV < 8mV

The balancing is also not performed if the cell voltage is not "stable" (isStable returns false)
what means that the voltage difference between last "N" measurements is > 6mV
(or AnalogInputs::STABLE_VALUE_ERROR), in this case you should see a changing voltage on the cells.

@njozsef
Copy link
Contributor Author

njozsef commented Jul 13, 2014

hi Pawel
sorry.
fail is my repository. I stored the ISMPS_maxvalue from calculated max charge I. Need storing the little large value than MAX_I
I fixed this problem. added plus 0.1A
best regards, Jozsef

calibrate.cpp
+// +ANALOG_AMP(0.100)

void checkCalibrateIcharge()
{
//CHECKHARDWAREPIDVALIDCALIBRATE
//check 'overflow" ismpsvalue

                                 //need because freeze 'm' state (balancerdisplay). this value stored the ismps_limit
if (!checkCalibrate(MAX_CHARGE_I+ANALOG_AMP(0.100),AnalogInputs::IsmpsValue))
 {
   Screen::displayCalibrationErrorScreen(1);
 }

settings.SMPS_Upperbound_Value_ = x1;
//save calib status
settings.calibratedState_ = settings.calibratedState_ | 2; 
Settings::save();   


//info only
if (!checkCalibrate(MAX_CHARGE_I,AnalogInputs::Ismps))
 {
   Screen::displayCalibrationErrorScreen(2);
 }

}

@njozsef njozsef closed this as completed Jul 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants