Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipable output mod #1285

Closed
LazyNCoder opened this issue Mar 27, 2024 · 13 comments
Closed

Skipable output mod #1285

LazyNCoder opened this issue Mar 27, 2024 · 13 comments

Comments

@LazyNCoder
Copy link

Hi,

I know in recent versions the default output mod changed from 8 to 2. But I'm old school and I prefer it on good old 8.

In older versions, if the output mod wasn't matched, it would throw an unskippable error, but today I simply pressed 'next' without realizing it, which bypassed the modulus error.
sshot-2024-03-27- 13-21-00

Is there any way to force it to be unskippable? Otherwise it doesn't make any sense.

@Dendraspis
Copy link
Collaborator

Let's do it that way:

In older versions, if the output mod wasn't matched, it would throw an unskippable error

Yes, but dependent on other settings.
Just for information: it hasn't changed for years. 😁

but today I simply pressed 'next' without realizing it, which bypassed the modulus error.
Is there any way to force it to be unskippable? Otherwise it doesn't make any sense.

The reason is caused by disabling Auto Correct Crop Values.
If you disable it, the message becomes ignorable.

@LazyNCoder
Copy link
Author

That's correct, I disabled the "auto correct" because sometimes it changes way too much. Like, rounds 137 to 140.
I have to say, disabling this option is problematic. It crashes if the values are not mod 2 when you're using crop tool. Python doesn't accept it, and so on.

I still think it should be sensitive about what mod we chose. Especially now that mod 2 is default.

Anyway, Mr. Dendraspis sir, thank you for answering my basic questions with such a great attitude. I really appreciate it.

@Dendraspis
Copy link
Collaborator

Dendraspis commented Mar 27, 2024

I will have a look at what we can do about it...

@Dendraspis
Copy link
Collaborator

This could help to make everybody happy I guess:

@LazyNCoder
Copy link
Author

I can't thank you enough.

@LazyNCoder
Copy link
Author

Hi,

I got two problems with this new option.

1- It doesn't work on batch encodes I guess. I have "auto crop" on always. cropped 138px top and bottom (=804) and went on. Didn't care about output mod which was 8.

2- If you check the new option, ignore the warning by clicking on the accept button, uncheck it, it doesn't warn you anymore.

I enabled "Auto correct crop values" and it changed 138 to 140. Which I think is over-cropping.

@Dendraspis
Copy link
Collaborator

Dendraspis commented Mar 30, 2024

This option is just made to make the warning ignorable - the mechanism behind has not changed at all.

  1. This is probably because you've disabled Auto Correct Crop Values. Auto Crop values are adjusted when this option is selected only.
  2. That is something that could be improved, indeed. 🤔

I enabled "Auto correct crop values" and it changed 138 to 140. Which I think is over-cropping.

But it should match Mod 8 then. So what would be your solution? Keeping a bit of the black bar?

@Dendraspis Dendraspis reopened this Mar 30, 2024
@LazyNCoder
Copy link
Author

But it should match Mod 8 then. So what would be your solution? Keeping a bit of the black bar?

Well yeah, 2px black bar is better than 2px of the image removed IMO

@Dendraspis
Copy link
Collaborator

I could add an option to decrease the crop rather than increase it. 🤔

@LazyNCoder
Copy link
Author

Well, it's awesome to have an option to choose whatever the user wants. But I still think if it crops more than it should, it would make the result invalid. Either way, any fix for this is appreciated 🙂

@Dendraspis
Copy link
Collaborator

Well yeah, 2px black bar is better than 2px of the image removed IMO

In your case 6px black bar vs 2px into the image.

But I still think if it crops more than it should, it would make the result invalid

It somehow feels like we're talking about different things. 🤔

You run Auto Crop and the outcome is odd or doesn't match the Output Mod, then Auto Correct Crop Values kicks in to match the Output Mod you have set. This means that the crop has to be extended.

I guess this is one reason why the very most users prefer using Mod 2 as this makes you loose max. 1px while not keeping any black bars.

@Dendraspis
Copy link
Collaborator

2- If you check the new option, ignore the warning by clicking on the accept button, uncheck it, it doesn't warn you anymore.

This was changed in v2.37.5.

@Dendraspis
Copy link
Collaborator

As far I can everything should be solved with v2.38.0, so I close this now....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants