Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Command macro %target_dir% missing "\" at the end. #1329

Open
noblemd00 opened this issue Apr 25, 2024 · 4 comments
Open

Event Command macro %target_dir% missing "\" at the end. #1329

noblemd00 opened this issue Apr 25, 2024 · 4 comments

Comments

@noblemd00
Copy link

noblemd00 commented Apr 25, 2024

Describe the bug
v.2.38.5

NOTE:
See Event command info below.
Is the Event Command macro change an error or a permanent (purposeful) change?

Encoded file with TARGET (example) location of: \10.15.1.47\TV\Active\W\Show.Folder.Name\0107.Episode.Name.mp4

This file ended up in with the name ...\W\Folder.Names0107.VideofileName.mp4 - NOTE: missing "" subfolder separator between "Folder.Name" and "0107".

I verified that the Target file location/path was correct.


I have an Event command active that changes the target file name to add "HDV" to the target name if the Template name contains "HDV" (see picture). "HDV" is my designation for HDR+DoVi encoded video.

%target_dir%%target_name%.%target_height%p.HDV.%encoder_ext%.%muxer_ext%

This Event command has always worked properly before. Now it seems %target_dir% does not contain the final backslash

Previously %target_dir% had a final backslash at the end.

I have temporarily changed the Event Command (added a backslash between %target_dir% and %target_name% )

%target_dir%(backslash)%target_name%.%target_height%p.HDV.%encoder_ext%.%muxer_ext%

240425 111418

Expected behavior
The finished file should end up in the proper folder with the proper name regardless of the file or path name complexity.

How to reproduce the issue

Encode a file and use the following Event command:

• Match All
Before Processing
Template Name Contains HDV

%target_dir%%target_name%.%target_height%p.HDV.%encoder_ext%.%muxer_ext%

@Dendraspis
Copy link
Collaborator

Indeed that is something I didn't have in mind when I released it, meaning without any notes about the missing backslash. 🙄
But this is now the way to go, so as you've already found out, the backslash has to be there since v2.38.1.

To be honest this is also better for reading and makes it easier to use in different approaches where the backslash at the end is not wanted.

Thanks to point that out, as it caused already problems like in #1326 .

@wrzlpete
Copy link

wrzlpete commented Apr 26, 2024

Ah great, I wasn't the only one getting old script errors thrown into my face when going from 2.38.0 to 2.38.5 :D
This seems to also affect %working_dir% etc.
So this stays, it's "safe" to adjust the templates to include the backlash from now on?

@Dendraspis
Copy link
Collaborator

It is. No matter what happens next, the ending backslash won't be included anymore in the directory name.

@wrzlpete
Copy link

Great, thx for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants