Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.7.0: DGIndex preprocessor puts BOM on d2v in codepage 65001(UTF-8) #435

Closed
JJKylee opened this issue Jan 10, 2021 · 0 comments
Closed

Comments

@JJKylee
Copy link
Contributor

JJKylee commented Jan 10, 2021

Describe the bug
On Windows 10 x64 (Home), when the system codepage is set to 65001(UTF-8), the DGIndex preprocessor in StaxRip 2.1.7.0 puts BOM on the d2v output making its encoding UTF-8 with BOM, not UTF-8 without BOM.
This makes the d2v file unreadable by both DGIndex.exe GUI and MPEG2Source(DGDecode.dll). They refuse the BOM mark.
#424 shows what kind of errors show up in that case.

I confirmed this issue with both DGMPGDec 1.5.8 (currently the default DGIndex shipped with 2.1.7.0) and DGMPGDec 2.0.01.

DGIndex itself does NOT put BOM in any situation - either in GUI or in CLI via CMD or PowerShell or CMD call from PowerShell. Please refer to this thread about this issue on DG Tools Forum. Only StaxRip DGIndex preprocessor puts BOM.

This is pretty weird seeing that by contrast DGIndexNV preprocessor does not put BOM on the output dgi file in the same UTF-8 codepage system.

Expected behavior
There should be no BOM on the output d2v file generated by the DGIndex preprocessor.

How to reproduce the issue

  1. Set the system codepage to UTF-8.
    Windows_Region_settings_UTF-8_20200313

  2. Restart Windows.

  3. Start StaxRip 2.1.7.0 (unmodded version) and open any MPEG2 video file.
    StaxRip_2 1 7 0_DGIndex_preprocessor_in_action_DGIndex-1 5 8_20210110

  4. The same error occurs even if DGIndex is updated to the most recent version 2.0.01

Provide more information

If you change the text encoding of the output d2v file from UTF-8 with BOM to UTF-8 without BOM, the error is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants