Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite #16

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

rewrite #16

wants to merge 19 commits into from

Conversation

kapdon
Copy link
Contributor

@kapdon kapdon commented May 13, 2024

  • alpine based multistage builder, 565.24mb compare to original 1.2gb give or take and a load less re-downloading.
  • auto invalidate git clone cache if upstream updates
  • pull PR if ARG exists (tested with Update Create-Release-with-SPT-AKI-Integration.yaml SIT.Aki-Server-Mod#53)
  • pull commit if ARG exists
  • defaults to pull branch other wise
  • uses commit_hash or pr_# as version file
  • flushed out version system to check for updates.
  • unified setup and entrypoint.sh
  • use screen instead as it does not require editing of AKI source code for compat
  • new ENVs
    • BACKEND_IP introduced in AKI 3.8.1
    • SERVER_NAME defaults to SIT + commit_hash
  • deletes js and js.map artifacts from mods folder before booting to eliminate user error
  • added sever and server-dev to git ignore.

I think that's everything, if it looks good I'll also update the documentation before merge or if you wanna stick to Ubuntu can also back port, but I think alpine is better suited.

entrypoint.alpine.sh Outdated Show resolved Hide resolved
entrypoint.alpine.sh Outdated Show resolved Hide resolved
Dockerfile.alpine Outdated Show resolved Hide resolved
Dockerfile.alpine Show resolved Hide resolved
forgot to update docker-compose
less delay and prompt user when terminal pause.
@kapdon
Copy link
Contributor Author

kapdon commented May 14, 2024

  • adds support for HEADLESS, default true and UPDATE default false flags
  • added LOG_REQUESTS defaults to true
  • fixed echo to only print after config is modified but not before
  • fetch external IP automatically
  • pause for 5 seconds if new build is detected but user has UPDATE flags unset.
  • supports package.json as version file for release builds.
  • split development and release to different docker build --target
    • should default to release if no target provided ( need 2nd pair of eyeballs to confirm )

make sure the initial bg AkiServer is actually killed
fix logic to print version diff regardless if update is true or not, and always update if update is true.
make sure the echo value after they are modified to ensure it's written properly and not before
screen termination unneeded
temp fix
lol git lfs n git drama
make aki install dir easier to change for upcoming 3.9
- introduce BREAKING_CHANGE flag in build step
- remove UPDATE flag always update installation by default, unless BREAKING_CHANGE detected.
- only quit after initial installation, else HEADLESS by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants