Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the navigation menu to use something other than NavigationView #238

Merged
merged 8 commits into from
May 7, 2024

Conversation

artehe
Copy link
Collaborator

@artehe artehe commented May 1, 2024

The fluent nav menu kept annoying me and had weird bugs to do with using the back button on your mouse that you couldn't disable? So have changed it to something simpler using a split view, in general this seems to work as well, Also makes another change I wanted to make easier adding in the Stay In Tarkov image into the empty space in the menu, so for comparison i've put the two manager UIs below:

Current Manager
image

Updated Manager:
image

I'd love some more suggestions on how to improve the look of the launcher as well

@Plootie
Copy link
Collaborator

Plootie commented May 1, 2024

Damn that actually looks much better! We could maybe experiment with transparency? Haven't tested yet but something like a 60-80% alpha often looks nice. Might not look good in our case but worth a try?

@J0nathan550
Copy link
Contributor

I don't like the margin on the menu bar if it is possible to change it can you remove it?
(Talking about this)
Screenshot_3
And can we make in a breadcrumb? and extend view to title bar to make it more fluent?

@J0nathan550
Copy link
Contributor

We can make something like this I made while ago in my "SoundScapes" project. here is the video of what I am talking about.

2024-05-02.12-56-49.mp4

@devbence
Copy link
Member

devbence commented May 2, 2024

if you dont mind, i might chime in with a minor request, can we set the SPT-AKI to AKI-SERVER?
the way it is now, creates confusion

thanks

@Plootie
Copy link
Collaborator

Plootie commented May 3, 2024

I don't like the margin on the menu bar if it is possible to change it can you remove it? (Talking about this) Screenshot_3 And can we make in a breadcrumb? and extend view to title bar to make it more fluent?

Personally I like moving the text away from the edge. Maybe reduce the margin by a few pixels instead?

@artehe
Copy link
Collaborator Author

artehe commented May 3, 2024

I don't like the margin on the menu bar if it is possible to change it can you remove it? (Talking about this) Screenshot_3 And can we make in a breadcrumb? and extend view to title bar to make it more fluent?

Personally I like moving the text away from the edge. Maybe reduce the margin by a few pixels instead?

I agree have reduced the margin by half, as I do agree it was a little bit far away.

@artehe
Copy link
Collaborator Author

artehe commented May 3, 2024

We can make something like this I made while ago in my "SoundScapes" project. here is the video of what I am talking about.
2024-05-02.12-56-49.mp4

I would be tempted to do something like this but as you can't extend into the title bar on Linux I feel like this would just look really off there.

@artehe
Copy link
Collaborator Author

artehe commented May 3, 2024

if you dont mind, i might chime in with a minor request, can we set the SPT-AKI to AKI-SERVER? the way it is now, creates confusion

thanks

I went with replacing all instances of SPT-AKI with AKI server, in the english version at least 😄

@J0nathan550 would you mind doing the same for the other languages please?

@artehe artehe requested a review from Plootie May 3, 2024 09:49
@J0nathan550
Copy link
Contributor

if you dont mind, i might chime in with a minor request, can we set the SPT-AKI to AKI-SERVER? the way it is now, creates confusion

thanks

I went with replacing all instances of SPT-AKI with AKI server, in the english version at least 😄

@J0nathan550 would you mind doing the same for the other languages please?

Sure

Comment on lines 70 to 77
<SplitView Background="Black"
IsPaneOpen="True"
DisplayMode="Inline"
OpenPaneLength="166"
Grid.Row="1">
<SplitView.Pane>
<Grid RowDefinitions="Auto, *, Auto"
Background="Black">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out #080808 and IMO it looks a little nicer. Could give it a try and see how ya feel about it? :3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okie I went with it.

@artehe artehe requested a review from Plootie May 7, 2024 17:10
@artehe artehe mentioned this pull request May 7, 2024
Copy link
Collaborator

@Plootie Plootie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :3

@artehe artehe merged commit 59aeb33 into master May 7, 2024
2 checks passed
@artehe artehe deleted the simplicity-is-sometimes-best branch May 7, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants