Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strings not localising #253

Merged
merged 2 commits into from
May 13, 2024
Merged

Fix strings not localising #253

merged 2 commits into from
May 13, 2024

Conversation

artehe
Copy link
Collaborator

@artehe artehe commented May 7, 2024

Use a different textblock and just show or hide it as necessary so that it will reload the localised string properly.

Resolve #235

Copy link
Collaborator

@Plootie Plootie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious. Would it be worth using the StringConverters.IsNullOrEmpty for the visibility over doing it in the viewmodel? Either way works good so just reminding ya it exists if you wanna use it. If not all good to merge!

@artehe
Copy link
Collaborator Author

artehe commented May 8, 2024

Just curious. Would it be worth using the StringConverters.IsNullOrEmpty for the visibility over doing it in the viewmodel? Either way works good so just reminding ya it exists if you wanna use it. If not all good to merge!

I knew I was doing something stupid, was literally thinking like I'm not doing this right. I shall sort it.

@Plootie Plootie merged commit 02dc1ce into master May 13, 2024
2 checks passed
@artehe artehe deleted the fix-localisation-not-working branch May 15, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Localization in some pages doesn't translate some keys when localization is changed.
2 participants