Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Fixes #266

Merged
merged 6 commits into from
May 16, 2024
Merged

Various Fixes #266

merged 6 commits into from
May 16, 2024

Conversation

artehe
Copy link
Collaborator

@artehe artehe commented May 15, 2024

A few fixes and tweaks to hopefully improve things:

  1. Reduce the excessive number of pings to bookmarked servers as it would be pinging the server even when the view wasn't activated
  2. Add a first super basic check for installing to OneDrive should resolve Block installing into OneDrive #245
  3. Fix the manager getting confused and showing multiple text over each other when looking at EFT settings
  4. Show a more helpful error message when unable to determine a SIT version to install.

@artehe artehe mentioned this pull request May 16, 2024
Open
Plootie
Plootie reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@Plootie Plootie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, other than that good to merge :3

SIT.Manager/ViewModels/Installation/ConfigureSitViewModel.cs Outdated Show resolved Hide resolved
@artehe artehe merged commit 22666ae into master May 16, 2024
2 checks passed
@artehe artehe deleted the fixes branch May 16, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Plootie Plootie Plootie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block installing into OneDrive
2 participants
@artehe @Plootie