Skip to content

Commit

Permalink
After [36171] remove all the occurrences of the old CSS clearfix.
Browse files Browse the repository at this point in the history
The old clearfix was applied to very specific items and defined multiple times
across CSS files. Uses the new generic `.wp-clearfix` utility class instead.

See #26396.

git-svn-id: https://develop.svn.wordpress.org@36422 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
afercia committed Jan 30, 2016
1 parent b9e1918 commit 25732e1
Show file tree
Hide file tree
Showing 13 changed files with 24 additions and 72 deletions.
8 changes: 0 additions & 8 deletions trunk/src/wp-admin/css/list-tables.css
Expand Up @@ -974,14 +974,6 @@ tr.inline-edit-row td,
line-height: 2.5;
}

.inline-edit-row fieldset .inline-edit-group:after {
content: ".";
display: block;
height: 0;
clear: both;
visibility: hidden;
}

.inline-edit-row p.submit {
clear: both;
padding: 0.5em;
Expand Down
17 changes: 0 additions & 17 deletions trunk/src/wp-admin/css/nav-menus.css
Expand Up @@ -747,23 +747,6 @@ body.menu-max-depth-11 { min-width: 1280px !important; }
margin-left: -4px;
}

/* Clearfix */
#menu-item-name-wrap:after,
#menu-item-url-wrap:after,
#menu-name-label:after,
#menu-settings-column .inside:after,
#nav-menus-frame:after,
.nav-menus-php #post-body-content:after,
.nav-menus-php .button-controls:after,
.nav-menus-php .major-publishing-actions:after,
.nav-menus-php .menu-item-settings:after {
clear: both;
content: ".";
display: block;
height: 0;
visibility: hidden;
}

#nav-menus-frame,
.button-controls,
#menu-item-url-wrap,
Expand Down
15 changes: 0 additions & 15 deletions trunk/src/wp-admin/css/themes.css
Expand Up @@ -524,14 +524,6 @@
-webkit-overflow-scrolling: touch;
}

.theme-overlay .theme-wrap:after {
content: ".";
display: block;
height: 0;
clear: both;
visibility: hidden;
}

body.folded .theme-overlay .theme-wrap {
left: 70px;
}
Expand All @@ -545,13 +537,6 @@ body.folded .theme-overlay .theme-wrap {
overflow: auto;
padding: 2% 4%;
}
.theme-overlay .theme-about:after {
content: ".";
display: block;
height: 0;
clear: both;
visibility: hidden;
}

.theme-overlay .theme-actions {
position: absolute;
Expand Down
8 changes: 0 additions & 8 deletions trunk/src/wp-admin/css/widgets.css
Expand Up @@ -230,14 +230,6 @@ div#widgets-left .inactive-sidebar .widgets-sortables {

/* Widgets Right */

div#widgets-right:after {
content: ".";
display: block;
height: 0;
clear: both;
visibility: hidden;
}

div#widgets-right .sidebars-column-1,
div#widgets-right .sidebars-column-2 {
max-width: 450px;
Expand Down
2 changes: 1 addition & 1 deletion trunk/src/wp-admin/customize.php
Expand Up @@ -127,7 +127,7 @@
</a>
</div>

<div id="widgets-right"><!-- For Widget Customizer, many widgets try to look for instances under div#widgets-right, so we have to add that ID to a container div in the Customizer for compat -->
<div id="widgets-right" class="wp-clearfix"><!-- For Widget Customizer, many widgets try to look for instances under div#widgets-right, so we have to add that ID to a container div in the Customizer for compat -->
<div class="wp-full-overlay-sidebar-content" tabindex="-1">
<div id="customize-info" class="accordion-section customize-info">
<div class="accordion-section-title">
Expand Down
2 changes: 1 addition & 1 deletion trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php
Expand Up @@ -150,7 +150,7 @@ public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0
</div>
</div>

<div class="menu-item-settings" id="menu-item-settings-<?php echo $item_id; ?>">
<div class="menu-item-settings wp-clearfix" id="menu-item-settings-<?php echo $item_id; ?>">
<?php if ( 'custom' == $item->type ) : ?>
<p class="field-url description description-wide">
<label for="edit-menu-item-url-<?php echo $item_id; ?>">
Expand Down
8 changes: 4 additions & 4 deletions trunk/src/wp-admin/includes/class-wp-posts-list-table.php
Expand Up @@ -1405,7 +1405,7 @@ public function inline_edit() {
if ( !$bulk && $can_publish ) :
?>

<div class="inline-edit-group">
<div class="inline-edit-group wp-clearfix">
<label class="alignleft">
<span class="title"><?php _e( 'Password' ); ?></span>
<span class="input-text-wrap"><input type="text" name="post_password" class="inline-edit-password-input" value="" /></span>
Expand Down Expand Up @@ -1537,7 +1537,7 @@ public function inline_edit() {
<?php if ( post_type_supports( $screen->post_type, 'comments' ) || post_type_supports( $screen->post_type, 'trackbacks' ) ) :
if ( $bulk ) : ?>

<div class="inline-edit-group">
<div class="inline-edit-group wp-clearfix">
<?php if ( post_type_supports( $screen->post_type, 'comments' ) ) : ?>
<label class="alignleft">
<span class="title"><?php _e( 'Comments' ); ?></span>
Expand All @@ -1561,7 +1561,7 @@ public function inline_edit() {

<?php else : // $bulk ?>

<div class="inline-edit-group">
<div class="inline-edit-group wp-clearfix">
<?php if ( post_type_supports( $screen->post_type, 'comments' ) ) : ?>
<label class="alignleft">
<input type="checkbox" name="comment_status" value="open" />
Expand All @@ -1578,7 +1578,7 @@ public function inline_edit() {
<?php endif; // $bulk
endif; // post_type_supports comments or pings ?>

<div class="inline-edit-group">
<div class="inline-edit-group wp-clearfix">
<label class="inline-edit-status alignleft">
<span class="title"><?php _e( 'Status' ); ?></span>
<select name="_status">
Expand Down
10 changes: 5 additions & 5 deletions trunk/src/wp-admin/includes/nav-menu.php
Expand Up @@ -263,17 +263,17 @@ function wp_nav_menu_item_link_meta_box() {
?>
<div class="customlinkdiv" id="customlinkdiv">
<input type="hidden" value="custom" name="menu-item[<?php echo $_nav_menu_placeholder; ?>][menu-item-type]" />
<p id="menu-item-url-wrap">
<p id="menu-item-url-wrap" class="wp-clearfix">
<label class="howto" for="custom-menu-item-url"><?php _e( 'URL' ); ?></label>
<input id="custom-menu-item-url" name="menu-item[<?php echo $_nav_menu_placeholder; ?>][menu-item-url]" type="text" class="code menu-item-textbox" value="http://" />
</p>

<p id="menu-item-name-wrap">
<p id="menu-item-name-wrap" class="wp-clearfix">
<label class="howto" for="custom-menu-item-name"><?php _e( 'Link Text' ); ?></label>
<input id="custom-menu-item-name" name="menu-item[<?php echo $_nav_menu_placeholder; ?>][menu-item-title]" type="text" class="regular-text menu-item-textbox" />
</p>

<p class="button-controls">
<p class="button-controls wp-clearfix">
<span class="add-to-menu">
<input type="submit"<?php wp_nav_menu_disabled_check( $nav_menu_selected_id ); ?> class="button-secondary submit-add-to-menu right" value="<?php esc_attr_e('Add to Menu'); ?>" name="add-custom-menu-item" id="submit-customlinkdiv" />
<span class="spinner"></span>
Expand Down Expand Up @@ -540,7 +540,7 @@ function wp_nav_menu_item_post_type_meta_box( $object, $post_type ) {
<?php endif; ?>
</div><!-- /.tabs-panel -->

<p class="button-controls">
<p class="button-controls wp-clearfix">
<span class="list-controls">
<a href="<?php
echo esc_url( add_query_arg(
Expand Down Expand Up @@ -731,7 +731,7 @@ function wp_nav_menu_item_taxonomy_meta_box( $object, $taxonomy ) {
</ul>
</div><!-- /.tabs-panel -->

<p class="button-controls">
<p class="button-controls wp-clearfix">
<span class="list-controls">
<a href="<?php
echo esc_url(add_query_arg(
Expand Down
4 changes: 2 additions & 2 deletions trunk/src/wp-admin/includes/theme.php
Expand Up @@ -588,13 +588,13 @@ function customize_themes_print_templates() {
?>
<script type="text/html" id="tmpl-customize-themes-details-view">
<div class="theme-backdrop"></div>
<div class="theme-wrap">
<div class="theme-wrap wp-clearfix">
<div class="theme-header">
<button type="button" class="left dashicons dashicons-no"><span class="screen-reader-text"><?php _e( 'Show previous theme' ); ?></span></button>
<button type="button" class="right dashicons dashicons-no"><span class="screen-reader-text"><?php _e( 'Show next theme' ); ?></span></button>
<button type="button" class="close dashicons dashicons-no"><span class="screen-reader-text"><?php _e( 'Close details dialog' ); ?></span></button>
</div>
<div class="theme-about">
<div class="theme-about wp-clearfix">
<div class="theme-screenshots">
<# if ( data.screenshot[0] ) { #>
<div class="screenshot"><img src="{{ data.screenshot[0] }}" alt="" /></div>
Expand Down
10 changes: 5 additions & 5 deletions trunk/src/wp-admin/nav-menus.php
Expand Up @@ -647,7 +647,7 @@ function wp_nav_menu_max_depth( $classes ) {
<?php } // foreach ?>
</tbody>
</table>
<p class="button-controls"><?php submit_button( __( 'Save Changes' ), 'primary left', 'nav-menu-locations', false ); ?></p>
<p class="button-controls wp-clearfix"><?php submit_button( __( 'Save Changes' ), 'primary left', 'nav-menu-locations', false ); ?></p>
<?php wp_nonce_field( 'save-menu-locations' ); ?>
<input type="hidden" name="menu" id="nav-menu-meta-object-id" value="<?php echo esc_attr( $nav_menu_selected_id ); ?>" />
</form>
Expand Down Expand Up @@ -714,7 +714,7 @@ function wp_nav_menu_max_depth( $classes ) {
</form>
<?php endif; ?>
</div><!-- /manage-menus -->
<div id="nav-menus-frame">
<div id="nav-menus-frame" class="wp-clearfix">
<div id="menu-settings-column" class="metabox-holder<?php if ( isset( $_GET['menu'] ) && '0' == $_GET['menu'] ) { echo ' metabox-holder-disabled'; } ?>">

<div class="clear"></div>
Expand Down Expand Up @@ -748,7 +748,7 @@ function wp_nav_menu_max_depth( $classes ) {
<input type="hidden" name="action" value="update" />
<input type="hidden" name="menu" id="menu" value="<?php echo esc_attr( $nav_menu_selected_id ); ?>" />
<div id="nav-menu-header">
<div class="major-publishing-actions">
<div class="major-publishing-actions wp-clearfix">
<label class="menu-name-label" for="menu-name"><?php _e( 'Menu Name' ); ?></label>
<input name="menu-name" id="menu-name" type="text" class="menu-name regular-text menu-item-textbox" <?php echo $menu_name_val . $menu_name_aria_desc; ?> />
<div class="publishing-action">
Expand All @@ -757,7 +757,7 @@ function wp_nav_menu_max_depth( $classes ) {
</div><!-- END .major-publishing-actions -->
</div><!-- END .nav-menu-header -->
<div id="post-body">
<div id="post-body-content">
<div id="post-body-content" class="wp-clearfix">
<?php if ( ! $add_new_screen ) : ?>
<h3><?php _e( 'Menu Structure' ); ?></h3>
<?php $starter_copy = ( $one_theme_location_no_menus ) ? __( 'Edit your default menu by adding or removing items. Drag each item into the order you prefer. Click Create Menu to save your changes.' ) : __( 'Drag each item into the order you prefer. Click the arrow on the right of the item to reveal additional configuration options.' ); ?>
Expand Down Expand Up @@ -822,7 +822,7 @@ function wp_nav_menu_max_depth( $classes ) {
</div><!-- /#post-body-content -->
</div><!-- /#post-body -->
<div id="nav-menu-footer">
<div class="major-publishing-actions">
<div class="major-publishing-actions wp-clearfix">
<?php if ( 0 != $menu_count && ! $add_new_screen ) : ?>
<span class="delete-action">
<a class="submitdelete deletion menu-delete" href="<?php echo esc_url( wp_nonce_url( add_query_arg( array( 'action' => 'delete', 'menu' => $nav_menu_selected_id ), admin_url( 'nav-menus.php' ) ), 'delete-nav_menu-' . $nav_menu_selected_id) ); ?>"><?php _e('Delete Menu'); ?></a>
Expand Down
4 changes: 2 additions & 2 deletions trunk/src/wp-admin/themes.php
Expand Up @@ -402,13 +402,13 @@

<script id="tmpl-theme-single" type="text/template">
<div class="theme-backdrop"></div>
<div class="theme-wrap">
<div class="theme-wrap wp-clearfix">
<div class="theme-header">
<button class="left dashicons dashicons-no"><span class="screen-reader-text"><?php _e( 'Show previous theme' ); ?></span></button>
<button class="right dashicons dashicons-no"><span class="screen-reader-text"><?php _e( 'Show next theme' ); ?></span></button>
<button class="close dashicons dashicons-no"><span class="screen-reader-text"><?php _e( 'Close details dialog' ); ?></span></button>
</div>
<div class="theme-about">
<div class="theme-about wp-clearfix">
<div class="theme-screenshots">
<# if ( data.screenshot[0] ) { #>
<div class="screenshot"><img src="{{ data.screenshot[0] }}" alt="" /></div>
Expand Down
4 changes: 2 additions & 2 deletions trunk/src/wp-admin/widgets.php
Expand Up @@ -455,12 +455,12 @@
if ( $sidebars_count > 1 ) {
$split = ceil( $sidebars_count / 2 );
} else {
$single_sidebar_class = ' class="single-sidebar"';
$single_sidebar_class = ' single-sidebar';
}

?>
<div class="widget-liquid-right">
<div id="widgets-right"<?php echo $single_sidebar_class; ?>>
<div id="widgets-right" class="wp-clearfix<?php echo $single_sidebar_class; ?>">
<div class="sidebars-column-1">
<?php

Expand Down
4 changes: 2 additions & 2 deletions trunk/src/wp-includes/class-wp-customize-nav-menus.php
Expand Up @@ -759,11 +759,11 @@ public function available_items_template() {
</h4>
<div class="accordion-section-content customlinkdiv">
<input type="hidden" value="custom" id="custom-menu-item-type" name="menu-item[-1][menu-item-type]" />
<p id="menu-item-url-wrap">
<p id="menu-item-url-wrap" class="wp-clearfix">
<label class="howto" for="custom-menu-item-url"><?php _e( 'URL' ); ?></label>
<input id="custom-menu-item-url" name="menu-item[-1][menu-item-url]" type="text" class="code menu-item-textbox" value="http://">
</p>
<p id="menu-item-name-wrap">
<p id="menu-item-name-wrap" class="wp-clearfix">
<label class="howto" for="custom-menu-item-name"><?php _e( 'Link Text' ); ?></label>
<input id="custom-menu-item-name" name="menu-item[-1][menu-item-title]" type="text" class="regular-text menu-item-textbox">
</p>
Expand Down

0 comments on commit 25732e1

Please sign in to comment.