-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support React 18 #164
Conversation
Hello @andipaetzold, thanks for adding support for React 18, just wanted to mention that the types of React do not use So can you please alter the ...
export class HelmetProvider extends React.Component<React.PropsWithChildren<ProviderProps>> {
static canUseDOM: boolean;
}
... Thanks a lot 🌷 |
@bacali95 Good catch, I am gonna update the PR to ensure it is compatible with both |
@bacali95 I just updated the PR |
Hey @andipaetzold thanks for the quick fix 🌷 Hey @staylor can please review/approve this PR 🌷 |
this needs to be rebased on your side, then I can merge it |
@types/react v17 added the children prop automatically. This changed with v18. Now, PropsWithChildren needs to be manually added.
@staylor done |
This reverts commit 8818bbe.
I have a workaround to fix this issue by myself. I'm waiting for this PR. export interface HelmetProps { interface ProviderProps { |
Thanks for this PR. Looking forward to the next release. 😄 |
Thank you 🚀 |
React 18 doesn't have any relevant breaking changes.
closes #163
closes #166