Skip to content

Commit

Permalink
Revert "Merge pull request openshift#28233 from candita/OCPBUGS-5943-…
Browse files Browse the repository at this point in the history
…revertKnownProblem"

This reverts commit 0098195, reversing
changes made to 72fa973.
  • Loading branch information
stbenjam committed Nov 6, 2023
1 parent 0b52f41 commit 095e457
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
Expand Up @@ -223,6 +223,10 @@ var KnownEventsBugs = []KnownProblem{
Regexp: regexp.MustCompile("ns/openshift-etcd-operator namespace/openshift-etcd-operator -.*rpc error: code = Canceled desc = grpc: the client connection is closing.*"),
BZ: "https://bugzilla.redhat.com/show_bug.cgi?id=2006975",
},
{
Regexp: regexp.MustCompile("reason/TopologyAwareHintsDisabled"),
BZ: "https://issues.redhat.com/browse/OCPBUGS-13366",
},
{
Regexp: regexp.MustCompile("ns/.*reason/.*APICheckFailed.*503.*"),
BZ: "https://bugzilla.redhat.com/show_bug.cgi?id=2017435",
Expand Down
15 changes: 7 additions & 8 deletions pkg/monitortests/testframework/watchevents/event_test.go
Expand Up @@ -98,26 +98,25 @@ func Test_recordAddOrUpdateEvent(t *testing.T) {
expectedMessage: "pathological/true interesting/true reason/SomethingHappened Readiness probe failed (40 times)",
},
{
name: "allowed pathological event with known bug (BZ 2000234)",
name: "allowed pathological event with known bug",
args: args{
ctx: context.TODO(),
m: monitor.NewRecorder(),
kubeEvent: &corev1.Event{
Count: 40,
Reason: "ns/openshift-etcd pod/etcd-quorum-guard-42 node/worker-42 - reason/Unhealthy",
Reason: "TopologyAwareHintsDisabled",
InvolvedObject: corev1.ObjectReference{
Kind: "Pod",
Namespace: "openshift-etcd",
Name: "etcd-quorum-guard-42",
Namespace: "any",
Name: "any",
},
Message: "Readiness probe failed:",
Message: "irrelevant",
LastTimestamp: metav1.Now(),
},
significantlyBeforeNow: now.UTC().Add(-15 * time.Minute),
},
// hmsg in expectedLocator is the hash of the entire expectedMessage except the number of times
expectedLocator: "ns/openshift-etcd pod/etcd-quorum-guard-42 hmsg/9100aa725d",
expectedMessage: "pathological/true interesting/true reason/ns/openshift-etcd pod/etcd-quorum-guard-42 node/worker-42 - reason/Unhealthy Readiness probe failed: (40 times)",
expectedLocator: "ns/any pod/any hmsg/e13faa98ab",
expectedMessage: "pathological/true interesting/true reason/TopologyAwareHintsDisabled irrelevant (40 times)",
},
}
for _, tt := range tests {
Expand Down

0 comments on commit 095e457

Please sign in to comment.