Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphviz files not parsable #25

Closed
LeifAndersen opened this issue Jun 25, 2017 · 2 comments
Closed

Graphviz files not parsable #25

LeifAndersen opened this issue Jun 25, 2017 · 2 comments

Comments

@LeifAndersen
Copy link
Contributor

When a graph contains a bunch of structs (rather than just symbols or strings), the graphviz files produced by the graphviz call looks something like this:

digraph G {
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	#<sink-node>;
	#<source-node>;
	#<source-node>;
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	#<filter-node>;
	subgraph U {
		edge [dir=none];
	}
	subgraph D {
		#<filter-node> -> #<filter-node> [label=2];
		#<filter-node> -> #<filter-node> [label=1];
		#<filter-node> -> #<filter-node> [label=1];
		#<filter-node> -> #<filter-node> [label=+inf.0];
		#<filter-node> -> #<filter-node> [label=+inf.0];
		#<filter-node> -> #<filter-node> [label=+inf.0];
		#<filter-node> -> #<sink-node> [label=+inf.0];
		#<source-node> -> #<filter-node> [label=+inf.0];
		#<source-node> -> #<filter-node> [label=+inf.0];
		#<filter-node> -> #<filter-node> [label=+inf.0];
		#<filter-node> -> #<filter-node> [label=1];
		#<filter-node> -> #<filter-node> [label=+inf.0];
		#<filter-node> -> #<filter-node> [label=1];
		#<filter-node> -> #<filter-node> [label=2];
	}
}

This is particularly problematic because #<filter-node> is not a valid node identifier in graphviz. In particular, when I run it, I get this error:

Error: :2: syntax error near line 2 context: >>> # <<< ; 

What would be better is give each node a unique (graphviz complaint) identifier, and use the name field to name the node.

@LeifAndersen
Copy link
Contributor Author

Also, the graphviz function, as is, won't work if any two nodes have the same name.

@LeifAndersen
Copy link
Contributor Author

Closed by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant