Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixgraphviz #26

Merged
merged 5 commits into from
Jun 29, 2017
Merged

Fixgraphviz #26

merged 5 commits into from
Jun 29, 2017

Conversation

LeifAndersen
Copy link
Contributor

No description provided.

@LeifAndersen
Copy link
Contributor Author

This addresses Issue #25

@stchang
Copy link
Owner

stchang commented Jun 26, 2017

Do you know why the tests are failing? I'm not sure the pretty-lib dep needed?

@LeifAndersen
Copy link
Contributor Author

Ah, good point. I guess I was just too used to needing the unstable-pretty-lib collection. I'll fix that.

@LeifAndersen
Copy link
Contributor Author

As for the other tests, it looks like that's because its testing for the hardcoded string, which is not right when we give each node a unique name. I'll see if I can think of a way to fix those tests.

@stchang stchang merged commit 1bc1a64 into stchang:master Jun 29, 2017
@stchang
Copy link
Owner

stchang commented Jun 29, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants