Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: test workflow is not running tests in nested test directories #2096

Open
2 tasks done
kgryte opened this issue Mar 31, 2024 · 0 comments
Open
2 tasks done

[BUG]: test workflow is not running tests in nested test directories #2096

kgryte opened this issue Mar 31, 2024 · 0 comments
Assignees
Labels
Bug Something isn't working. CI Issue or pull request specific to continuous integration environments.

Comments

@kgryte
Copy link
Member

kgryte commented Mar 31, 2024

Description

In https://github.com/stdlib-js/stdlib/actions/runs/8496433869/job/23273812132?pr=1680, I noticed that not all tests were running. As can be observed in #1680, we have tests in nested directories. Locally, these tests were failing, but CI did not catch. The reason for this is that CI only attempts to run tests at the top-level of the test folder within a package.

Line which needs to be updated:

files=$(find ${directories} -maxdepth 2 -wholename '**/test/test*.js' | grep -v '/fixtures/' | sort -u | tr '\n' ' ') || true

Related Issues

No.

Questions

  • What was the rationale for limiting test filtering to the top-level test directory? Why were nested tests ignored?

Demo

No response

Reproduction

Expected Results

No response

Actual Results

No response

Version

No response

Environments

Node.js

Browser Version

No response

Node.js / npm Version

No response

Platform

No response

Checklist

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
@kgryte kgryte added Bug Something isn't working. CI Issue or pull request specific to continuous integration environments. labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. CI Issue or pull request specific to continuous integration environments.
Projects
None yet
Development

No branches or pull requests

2 participants