Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: add sind #32

Open
4 tasks done
kgryte opened this issue Dec 6, 2016 · 11 comments · May be fixed by #487
Open
4 tasks done

RFC: add sind #32

kgryte opened this issue Dec 6, 2016 · 11 comments · May be fixed by #487
Labels
difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Help Wanted Extra attention is needed. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes.
Projects

Comments

@kgryte
Copy link
Member

kgryte commented Dec 6, 2016

Checklist

Please ensure the following tasks are completed before filing an issue.

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • If this is a general question, searched the FAQ for an existing answer.
  • If this is a feature request, the issue name begins with RFC: .

Description

Description of the issue (or feature request).

Compute the sine of x where x is in degrees.

Package: @stdlib/math/base/special/sind
Alias: base.sind

For a reference implementation, see Julia.

Related Issues

Does this issue (or feature request) have any related issues?

No.

Questions

Any questions for reviewers?

No.

Other

Any other information relevant to this issue (or feature request)? This may include screenshots, references, stack traces, sample output, and/or implementation notes.

No.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Dec 6, 2016
@rreusser
Copy link
Member

rreusser commented May 6, 2017

Are the degree modules one-liners that multiply by pi / 180 and call out to other functions?

@kgryte
Copy link
Member Author

kgryte commented May 6, 2017

Not necessarily, as one can perform argument reduction for better accuracy. See Julia, for example.

@kgryte
Copy link
Member Author

kgryte commented May 6, 2017

Based on the reference implementation, implementing this package depends on kernel sin.

cc/ @Planeshifter

@vinothdinakar
Copy link

I see the above comments on May 6. Is anyone working on this? or can I try ?

@kgryte
Copy link
Member Author

kgryte commented Aug 21, 2017

No one was yet to work on this as we have yet to implement kernel sin. @Planeshifter may have some insight into timelines for this.

@kgryte kgryte changed the title Implement sind RFC: add sind Aug 21, 2017
@Planeshifter
Copy link
Member

The kernel sin function is already there inside of @stdlib/math/base/special/sin, but needs to be separated into its own package. I can make this a high-priority item and work on this soon so that @vinothdinakar can tackle sind.

@kgryte
Copy link
Member Author

kgryte commented Aug 21, 2017

@Planeshifter Looks like we will also need kernel cosine, as well.

@Planeshifter
Copy link
Member

Planeshifter commented Aug 21, 2017

If you want to start working on this, @vinothdinakar, you could require the internal package functions directly for now, as in

var kernelSin = require( '@stdlib/math/base/special/sin/lib/kernel_sin.js' );

We can then replace the require statements once the standalone packages are up. I will have the kernel packages done by the end of the week, at latest.

@kgryte
Copy link
Member Author

kgryte commented Aug 21, 2017

@Planeshifter Awesome!

@vinothdinakar Feel free to submit a PR once you have a working prototype.

@vinothdinakar
Copy link

Ok Thanks

@kgryte
Copy link
Member Author

kgryte commented Aug 30, 2017

@vinothdinakar Just to give you an update, @Planeshifter managed to implement the various kernel packages:

@stdlib/math/base/special/kernel-sin
@stdlib/math/base/special/kernel-cos

So, if you are still interested and/or already working on it, feel free to use the above packages. :)

Updated reference implementation: https://github.com/JuliaLang/julia/blob/9ef2af9db620644253941e080b5b4986ad0d6091/base/special/trig.jl#L1017

@kgryte kgryte added Help Wanted Extra attention is needed. RFC Request for comments. Feature requests and proposed changes. labels Oct 23, 2018
@AlisaLC AlisaLC linked a pull request Feb 5, 2022 that will close this issue
1 task
@kgryte kgryte mentioned this issue Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Help Wanted Extra attention is needed. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes.
Projects
Features
Backlog
Development

Successfully merging a pull request may close this issue.

4 participants