New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for testing whether a value is a constant-cased string #540
Conversation
I don't have the access to add assignees for the PR :/ Edit: Thanks :) |
@Pranavchiku Sorry about that. This is the first time I'm trying this out. Just assigned. Let's see what happens. |
Looks like the workflow is stuck in a queue, so we'll need to wait a while for it to kick off. How long we'll have to wait is TBD. |
It might get failed if stuck there for long time ( I faced this issue once at lfortran ) |
Okay, so there are currently problems with the AI scaffolding workflow when triggered from a fork, which we will need to look into. Apologies! As a temporary workaround, I have created a Feel free to either checkout that branch or copy the files over into this PR's branch. |
I rebased it over my PR, and added implementation, made a clean build again, there are quite a few bugs like output not correctly predicted, linting errors, and a few things will be needed to fix before I can push those changes in this PR, will try to get that done as soon as possible :) |
Thanks for trying this out @Pranavchiku! |
Sorry for delaying it, will try to get the things up as soon as possible. |
so, tape( 'the command-line interface supports use as a standard stream', opts, function test( t ) {
var cmd = [
'printf "BEEP\nboop"',
'|',
EXEC_PATH,
fpath
];
exec( cmd.join( ' ' ), done );
function done( error, stdout, stderr ) {
if ( error ) {
t.fail( error.message );
} else {
t.strictEqual( stdout.toString(), 'true\ntrue\n', 'expected value' );
t.strictEqual( stderr.toString(), '', 'does not print to `stderr`' );
}
t.end();
}
}); This test is not passing in
|
@Pranavchiku Left a comment. You may need to merge in changes from upstream. Currently, this PR is a bit "dirty" in that it contains changes/files which are already present in the upstream repo. |
Yeah I will do that. |
I observed few things on the files created by
Rest everything was very perfect! |
@Pranavchiku That's great feedback! Thanks! cc @Planeshifter |
I am currently getting a small error in |
@Pranavchiku Awesome! Thanks for working on this! |
lib/node_modules/@stdlib/assert/is-constantcase/test/test.cli.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/assert/is-constantcase/test/test.cli.js
Outdated
Show resolved
Hide resolved
@kgryte you can have a final review. |
lib/node_modules/@stdlib/assert/is-constantcase/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Pranavchiku!
Thank you @Pranavchiku for the feedback. 1., 2., and 4. will be fixed in the next iteration of the scaffolding tool. We will keep iterating to hopefully get to a very smooth development experience in the near future. |
Resolves #534.
Checklist
@kgryte